Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror 26447: Curtains fix #450

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26447: Curtains fix from space-wizards space-wizards/space-station-14

55b146a16c74d9b1ef4991f3ad3e22b15267f56f

PR opened by Futuristic-OK at 2024-03-26 13:45:20 UTC - merged at 2024-03-26 16:03:54 UTC


PR changed 2 files with 13 additions and 31 deletions.

The PR had the following labels:

  • No C#

Original Body

About the PR

Now curtains can be built and opened inside walls and windows, etc.
(There is a mistake that if the curtain is opened outside the 180 degree range, the sound of the curtains opening will not be played by the player himself. All the surrounding players and ghosts will still hear the sound.

Why / Balance

Why not?

Technical details

A few lines of code

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Erm... Nothing?

Changelog

  • tweak: Сurtains can be built and opened inside full tiles

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Jun 11, 2024
@Pspritechologist Pspritechologist added Status: Derelict Has not been active for a while and removed Status: Derelict Has not been active for a while labels Jun 11, 2024
@VMSolidus VMSolidus marked this pull request as ready for review June 12, 2024 16:39
@DangerRevolution DangerRevolution merged commit 8594381 into Simple-Station:master Jun 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants