Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Paper Signatures #456

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

Mnemotechnician
Copy link
Contributor

Description

Ports delta-v paper signatures implemented by me in DeltaV-Station/Delta-v#1172, including the changes later introduced by deltanedas in DeltaV-Station/Delta-v#1345.

Everything should be pretty self-explanatory, see the original PR for details.


Media

image

(see the original PR for a video demonstation)


Changelog

🆑

  • add: You can now sign paper by alt-clicking it while holding a pen.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI labels Jun 13, 2024
Copy link
Contributor

github-actions bot commented Jun 13, 2024

RSI Diff Bot; head commit f44b1b1 merging into 2138b8a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Misc/bureaucracy.rsi

State Old New Status
paper_stamp-signature Added

Edit: diff updated after f44b1b1

@DangerRevolution DangerRevolution added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature labels Jun 13, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be taken out of Delta folders; and would be nice just for the paper trail if you could link the PR on Frontier this is originally ported from :)

Otherwise; all okay, just a question if this works with agent ID's?

@Mnemotechnician
Copy link
Contributor Author

This is not taken from frontier. The idea is, but the implementation is unique. And yes, it works with agent IDs: the screenshot portrays a paper with a signature saying "Agent Gamma". That signature was made using an agent ID.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be taken out of Delta folders

Content.Server/DeltaV/Paper/SignAttemptEvent.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Paper/SignatureSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Paper/SignatureSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Paper/SignatureSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Paper/SignatureSystem.cs Outdated Show resolved Hide resolved
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: Mnemotechnican <[email protected]>
@SimpleStation14 SimpleStation14 changed the title Port paper signatures Port Paper Signatures Jun 19, 2024
@DangerRevolution
Copy link
Contributor

@DEATHB4DEFEAT concerns seem to have been addressed; re-requested review :)

Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: Mnemotechnican <[email protected]>
@VMSolidus VMSolidus merged commit 476e6de into Simple-Station:master Jul 5, 2024
13 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants