Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Station Goals #465

Merged
merged 14 commits into from
Jun 17, 2024
Merged

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Jun 16, 2024

Description

Simple-Station/Parkstation-Friendly-Chainsaw#10

This adds a feature whereby a random goal for the shift is faxed to the station's Captain at the start of every shift.
It is up to the Captain to decide if and how this goal is to be completed.
Goals are randomly generated every shift, and are meant to help encourage station activity and RP.
Admins are also able to send station goals via sendstationgoal.


Media

stationgoals


Changelog

🆑 VMSolidus

  • add: Added station goals that get sent to the Command fax machine at the start of every shift

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Jun 16, 2024
@VMSolidus
Copy link
Member Author

@stellar-novas Yep, I got it for you, thanks for the catch.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More grammar issues I don't plan to comment on; but uh, this really should be configurable to randomly send / non-send goals.

Content.Server/Corvax/GameTicking/RoundEndedEvent.cs Outdated Show resolved Hide resolved
Content.Server/Corvax/GameTicking/RoundStartedEvent.cs Outdated Show resolved Hide resolved
Content.Server/Corvax/StationGoal/StationGoalCommand.cs Outdated Show resolved Hide resolved
VMSolidus and others added 2 commits June 16, 2024 12:55
Co-authored-by: Danger Revolution! <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
@VMSolidus
Copy link
Member Author

More grammar issues I don't plan to comment on; but uh, this really should be configurable to randomly send / non-send goals.

Sure, I can do that real quick.

@VMSolidus

This comment was marked as resolved.

Content.Server/Fax/FaxMachineComponent.cs Outdated Show resolved Hide resolved
Content.Server/Fax/FaxMachineComponent.cs Outdated Show resolved Hide resolved
Content.Server/StationGoal/StationGoalPaperComponent.cs Outdated Show resolved Hide resolved
Content.Shared/CCVar/CCVars.cs Outdated Show resolved Hide resolved
Content.Server/StationGoal/StationGoalPaperSystem.cs Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Objects/Misc/paper.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Objects/Misc/paper.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Objectives/goals.yml Show resolved Hide resolved
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jun 16, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Port of Station Goals Port Station Goals Jun 16, 2024

var printout = new FaxPrintout(
Loc.GetString("station-goal-fax-paper-header",
("date", DateTime.Now.AddYears(1000).ToString("yyyy MMMM dd")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common core when?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

job for downstreams :godo:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

job for downstreams :godo:

common core is our job

@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Feature Creation of or significant changes to a feature labels Jun 16, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this; however I would appreciate if you could also make a footer for this paper.

Generic uh, farewell and a signature from Central Command or maybe some random name? 🤷, up to you if you want to do it or not. Can be done later.

/// <summary>
/// Chance for a station goal to be sent
/// </summary>
public static readonly CVarDef<float> StationGoalsChance =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

In addition, it is necessary to provide a public, well-lit corridor connecting all the restored compartments and new bedrooms.

station-goal-bureaucratic-error =
ACCESS TO THIS DOCUMENT IS PROHIBITED FOR PERSONS WHO DO NOT HAVE LEGAL IMMUNITY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what this means; given no one has legal immunity under any sort of Space Law (Delta or Wiz)

@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Port Station Goals Port station Goals Jun 17, 2024
@SimpleStation14 SimpleStation14 changed the title Port station Goals Port Station Goals Jun 17, 2024
@DEATHB4DEFEAT
Copy link
Member

Double approval :godmode:

@VMSolidus VMSolidus merged commit a9335db into Simple-Station:master Jun 17, 2024
12 of 13 checks passed
SimpleStation14 added a commit that referenced this pull request Jun 17, 2024
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Jun 21, 2024
# Description

Simple-Station/Parkstation-Friendly-Chainsaw#10

This adds a feature whereby a random goal for the shift is faxed to the
station's Captain at the start of every shift.
It is up to the Captain to decide if and how this goal is to be
completed.
Goals are randomly generated every shift, and are meant to help
encourage station activity and RP.
Admins are also able to send station goals via `sendstationgoal`.

---

<details><summary><h1>Media</h1></summary>
<p>


![stationgoals](https://github.com/Simple-Station/Einstein-Engines/assets/16548818/4a2b5533-dfee-4388-bfbc-043ee71b2647)

---

</p>
</details> 

# Changelog

:cl: VMSolidus
- add: Added station goals that get sent to the Command fax machine at
the start of every shift

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: Danger Revolution! <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants