Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Random Bark System #466

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Jun 16, 2024

Description

Simple-Station/Parkstation-Friendly-Chainsaw#11

Later, I would like to have this system not just for animals, but for implementations of humanoid NPCs, since it can just as easily be used for human NPCs.
I could make space bandits that CHEEKI BREEKI at people.

Changelog

🆑 DEATHB4DEFEAT

  • add: Animals will no longer be a silent, soulless shell

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jun 16, 2024
@VMSolidus VMSolidus changed the title Port of random bark system Port of Random Bark System Jun 16, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Port of Random Bark System Port Random Bark System Jun 16, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase labels Jun 16, 2024
@@ -104,3 +104,4 @@
- type: MobPrice
price: 150
- type: FloatingVisuals
- type: Speech
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to make the barks in the first place.

/// Multiplier applied to the random time. Good for changing the frequency without having to specify exact values
/// </summary>
[DataField, ViewVariables(VVAccess.ReadWrite)]
public float BarkMultiplier = 1f;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify; what does this do? Not really getting from the description

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It accelerates the rate at which barks accumulate. The higher the multiplier is, the more often the barks happen. Make it lower to make them bark less often.

Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this output using their language? I'm assuming it does...

Also; this is going to be insanely pedantic but I'd appreciate the changelog entry being changed to give more context as to what the actual change is, for when someone looks at the entries lol

@DEATHB4DEFEAT
Copy link
Member

Does this output using their language? I'm assuming it does...

It should.

Also; this is going to be insanely pedantic but I'd appreciate the changelog entry being changed to give more context as to what the actual change is, for when someone looks at the entries lol

The changelog is perfect.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for death; good enough for me

@DangerRevolution DangerRevolution merged commit bc0e2e6 into Simple-Station:master Jun 20, 2024
11 checks passed
SimpleStation14 added a commit that referenced this pull request Jun 20, 2024
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Jun 21, 2024
# Description

Simple-Station/Parkstation-Friendly-Chainsaw#11

Later, I would like to have this system not just for animals, but for
implementations of humanoid NPCs, since it can just as easily be used
for human NPCs.
I could make space bandits that CHEEKI BREEKI at people.

# Changelog

:cl: DEATHB4DEFEAT
- add: Animals will no longer be a silent, soulless shell

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants