Cherrypick "Shoot Over Bodies" And Related PRs #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMSolidus
added
Changes: C#
DangerRevolution
added
Status: Needs Review
DangerRevolution
requested review from
DEATHB4DEFEAT,
Pspritechologist and
DangerRevolution
|
Copy the bodies over from the previous PR's; so whoever comes looking doesn't have to dive down several links (and because I also don't want to dive down these links) |
Yea I just checked, I actually can't do that. |
DangerRevolution
approved these changes
Jun 20, 2024
Peptide90
approved these changes
Jun 22, 2024
DEATHB4DEFEAT
removed
the
Pull Request Mirror
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a manual cherry-pick of the following PRs:
space-wizards/space-station-14#27905
space-wizards/space-station-14#28072
space-wizards/space-station-14#28571
I REQUIRE these for my work in PR #11 , and cannot complete said PR without these cherry-picks. This set of PRs from Wizden adds a feature where entities can selectively opt-out of being shot at unless a player intentionally targets them, which I can use as a simple and elegant solution to one of the largest glaring issues for Segmented Entities. I could simply give Lamia segments the new RequireProjectileTargetComponent, which adds them to the system. Future segmented entities such as the hypothetical "Heretic Worm" may or may not use this feature, depending on their intended implementation.