Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mirror: Restrict Door Remotes to only Being Able to Manipulate Doors Relevant to Their Type" #491

Conversation

stellar-novas
Copy link
Contributor

Reverts #315

As I brought up in the original pr, this change was made to counter power gaming, which isn't as much of an issue on EE downstreams, and adversely affects the engineering department, without any major benefits.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jun 28, 2024
@SimpleStation14 SimpleStation14 changed the title Revert "Mirror: Restrict door remotes to only being able to manipulate doors relevant to their type" Revert "Mirror: Restrict Door Remotes to only Being Able to Manipulate Doors Relevant to Their Type" Jun 28, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jun 30, 2024
@DangerRevolution DangerRevolution added Priority: 4-Low Should be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed labels Jun 30, 2024
@DangerRevolution
Copy link
Contributor

Happy to merge but; thinking about it that it makes sense that a remote only opens what the remote is for?

@stellar-novas
Copy link
Contributor Author

I think it makes sense for a remote to be able to link up to the user's ID card.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be honest, if this gets two reviews and is merged that's okay but I am genuinely against it, I can't really get behind it...

@stellar-novas stellar-novas force-pushed the revert-315-space-wizards_space-station-14_26371_2024-04-22 branch from b0dfc16 to 8d0aff1 Compare July 21, 2024 03:27
stellar-novas and others added 2 commits July 28, 2024 14:25
not my fault i just pressed revert

Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: stellar-novas <[email protected]>
@stellar-novas stellar-novas force-pushed the revert-315-space-wizards_space-station-14_26371_2024-04-22 branch from b370558 to b4ddff5 Compare July 28, 2024 18:25
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 00a74a2 into Simple-Station:master Aug 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Priority: 4-Low Should be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants