Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Equip Delays to Clothing #499

Merged

Conversation

Mnemotechnician
Copy link
Contributor

@Mnemotechnician Mnemotechnician commented Jun 30, 2024

Description

For centuries SS14 had equip and unequip delays on the clothing component, and yet that feature remained unused and unheard of, not even nyanotrasen/deltav used it when designing shock collars and headcages, whose descriptions clearly suggested they should take time to take off. For centuries salvage specialists could safely swap suits in space. For centuries you could accidentally unequip your eva suit mid-spacewalk and die. Now the time has come. The time when we change it.

This adds equip and unequip delays to the base clothing item. The currently chosen time is half a second - it's meant to not be too annoying, but at the same time prevent people from being able to instantly swap clothes, headsets, other things with a single click.

EVA suits take 1.5 seconds to equip and 1 second to take off, so to swap EVA suits, you will have to expose your body to the dangers of space for at least 1.5 seconds. For hardsuits, both values are increased to 2.5 seconds.

The values are not final and this PR will probably need polishing before it can be merged - for example, while recording the second preview video, I discovered that jetpacks do not inherit from base clothing and thus do not inherit the delays. There's probably way more such items.


TODO

Add equip/unequip delays to:

  • most basic clothing items
  • hardsuits/softsuits
  • special items (currently headcages and shock collars, possibly more later?)
  • Everything that was missed by the above

Media

Basics

weeee-2024-06-30_20.20.44.mp4

Hardsuits, eva suits, shock collars, headcages + demonstration that aghost stripping is unaffected.

weeee-2024-06-30_20.37.13.mp4


Changelog

🆑

  • add: Most items now take time to equip and unequip, especially space suits.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jun 30, 2024
@SimpleStation14 SimpleStation14 changed the title Add equip delays to clothing Add Equip Delays to Clothing Jun 30, 2024
@DangerRevolution DangerRevolution added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature labels Jun 30, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just needs to be added to the headcage; which is parented to the tinfoil hat.

Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@VMSolidus
Copy link
Member

Headcages really need to have their own system for unequipping, which I'll visit at some point in my psychic refactor. I have my own plans for them(Involving needing an iron key found only in the Mantis & Mystagogue locker) and having the headcage be a part of glimmer management, but this is fine.

@DangerRevolution
Copy link
Contributor

but this is fine.

Adding a delay or the PR as a whole?

@VMSolidus
Copy link
Member

Adding a delay. :)
Also how can I add emotes to our github repo? I want to put the Farida emotes on here.

@DEATHB4DEFEAT
Copy link
Member

DEATHB4DEFEAT commented Jun 30, 2024

Also how can I add emotes to our github repo? I want to put the Farida emotes on here.

You can't, they're all built-in. :trollface:

@DangerRevolution
Copy link
Contributor

Adding a delay. :) Also how can I add emotes to our github repo? I want to put the Farida emotes on here.

https://github.com/StylishThemes/GitHub-Custom-Emojis/blob/master/README.md

@DangerRevolution
Copy link
Contributor

Also uh; before merge this just needs equip & un-equip delay on headcages and this should also be carried over to belts if it isn't already :)

@Mnemotechnician
Copy link
Contributor Author

Belts inherit from base clothing, so they're affected, and headcages were specifcally given an unequip delay of 6 seconds (though I can increase it more if you'd like)

@DangerRevolution
Copy link
Contributor

Belts inherit from base clothing, so they're affected, and headcages were specifcally given an unequip delay of 6 seconds (though I can increase it more if you'd like)

very sigma; same time as handcuffs so there's no worry about it.

@DangerRevolution DangerRevolution merged commit f439eb7 into Simple-Station:master Jun 30, 2024
22 checks passed
SimpleStation14 added a commit that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants