Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Them Pesky Job Requirements #511

Merged

Conversation

Mnemotechnician
Copy link
Contributor

Description

Fixes job requirements using wrong locales

Happened because one function had role-timer- as its default locale prefix and the other that called the first had null as the default.


Media

image

image


Changelog

🆑

  • fix: Job requirements are now displayed correctly.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jul 4, 2024
@SimpleStation14 SimpleStation14 changed the title Fix them pesky job requirements Fix Them Pesky Job Requirements Jul 4, 2024
@DangerRevolution
Copy link
Contributor

Mimic test fail lmao

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reviewed before Deepstation playtest please.

@DangerRevolution DangerRevolution merged commit d5f73ad into Simple-Station:master Jul 5, 2024
17 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 5, 2024
BlueHNT added a commit to BlueHNT/nuclear-14 that referenced this pull request Jul 9, 2024
Peptide90 pushed a commit to Vault-Overseers/nuclear-14 that referenced this pull request Jul 10, 2024
* authored by: @DangerRevolution

* changes `FromMarkup` to `FromMarkupPermissive`

* ports: Simple-Station/Einstein-Engines#511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants