Despecialize Jobs And Events #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DangerRevolution
suggested changes
Jul 5, 2024
Resources/Prototypes/Nyanotrasen/Roles/Jobs/Epistemics/forensicmantis.yml
Show resolved
Hide resolved
|
HoP AA and TC Disadvantage removal needs to have it's own PR's if intended. |
DangerRevolution
suggested changes
Jul 6, 2024
Co-authored-by: Danger Revolution! <[email protected]> Signed-off-by: VMSolidus <[email protected]>
|
Yea, that's all good. I pretty wholeheartedly agree with you that RandomSentience & ImmovableRod should be extremely rare. Having that ultra low 0.5 weight for both is fine. |
DEATHB4DEFEAT
approved these changes
Jul 10, 2024
|
Will review tonight unless someone beats me to it |
DangerRevolution
previously requested changes
Jul 12, 2024
Resources/Prototypes/Nyanotrasen/Roles/Jobs/Wildcards/martialartist.yml
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: VMSolidus <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A common complaint I have gotten from server hosts looking to setup servers on our codebase is that we have all of these leftover job and event modifications from DeltaV, which serve a purpose not present in our repository. I've taken the liberty of cleaning up and uncommenting a majority of events that DeltaV commented out for one reason or another at various times, and have also removed every single instance of pre-existing job playtime and whitelist requirements, as well as the antag factors. These especially are a point of contention for anyone wishing to setup a new server, because it's quite literally impossible for anyone on a brand new server that has only been existing for 20 minutes so far, to have the ~200 hours of playtime + whitelist that DeltaV would have required them to have to play Captain.
This update in turn leaves the onus on server hosts to set their own desired whitelist requirements as needed, rather than enforce DeltaV's unusually strict requirements that we inherited. Furthermore, the sheer number of commented out events from DeltaV was giving server hosts the false impression that we were lacking content compared to Wizden, when truthfully, our predecessor disabled a majority of the game's content, and it was simply never re-enabled. The only events I left commented out are the Terminator(which in our codebase has been superceded by the much better Paradox Anomaly), and the GlimmerWispSpawn, which remains commented due to Glimmer Wisps not yet being rebased.