Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dont Merge] Buckle Changes/Rework Incoming, Vehicle Implemenation and Proper Keys Functionality #521

Closed
wants to merge 8 commits into from

Conversation

Acensti
Copy link

@Acensti Acensti commented Jul 6, 2024

Description

This PR reworks the buckle system, splits keys into their own component, and implements a lightweight vehicle system as per wizden and my first PR and probably pathetic but i never coded for ss14 so i do apologize if you see horrendous mistakes just explain to me kindheartly why this is not good this is my first time at game dev in general that isnt unreal. I'm not done but i did do a lot of work which i just removed.


TODO

  • Rework Buckle System?
  • [] Split Keys into Their Own Component
  • [] Implement Lightweight Vehicle System
  • [] Docking system for mechs and vehicles

Media

Example Media Embed


Changelog

🆑

  • add: Reworked the buckle system to remove sprite layering and entity offset hacks.
  • add: Split keys into their own component.
  • add: Implemented a lightweight vehicle system with modular components.
  • tweak: Vehicles no longer have a hard requirement for keys but can be restricted with a KeyRequiredComponent.
  • fix: Fixed various issues with the buckle system.

sharedbucklesystem.buckle.cs and strap moved into sharedbucklesystem.cs.

In TG, Mobs were (if i remember right) assigned a entity that was able to be mounted or buckled upon, so just toss that onto a robot, cat or a fridge and you can buckle it.

TODO: alot

GOALS?
Goals:

Remove the hard requirement of keys from vehicles.
Split key logic into a separate component.
cars
vehicles
buckle to ian
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jul 6, 2024
@Acensti Acensti changed the title Vehiclemaybe [dont merge] Buckle changes/rework incoming, Vehicle implemenation and proper keys functionality Jul 6, 2024
@SimpleStation14 SimpleStation14 changed the title [dont merge] Buckle changes/rework incoming, Vehicle implemenation and proper keys functionality [Dont Merge] Buckle Changes/Rework Incoming, Vehicle Implemenation and Proper Keys Functionality Jul 6, 2024
@Acensti Acensti marked this pull request as draft July 6, 2024 19:50
@Acensti
Copy link
Author

Acensti commented Jul 6, 2024

Content.Server/Vehicles/UI/VehicleControlUI.cs
=> to client not server X)

@DangerRevolution DangerRevolution added Holy Shit Priority: 3-Medium Needs to be resolved at some point Size: 2-Large For large issues/PRs Type: Feature Creation of or significant changes to a feature labels Jul 6, 2024
@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an RSI label Jul 7, 2024
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DEATHB4DEFEAT
Copy link
Member

Closing due to inactivity, reopen if you ever return to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 2-Large For large issues/PRs Status: Merge Conflict FIX YOUR PR AAAGH Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants