-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dont Merge] Buckle Changes/Rework Incoming, Vehicle Implemenation and Proper Keys Functionality #521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharedbucklesystem.buckle.cs and strap moved into sharedbucklesystem.cs. In TG, Mobs were (if i remember right) assigned a entity that was able to be mounted or buckled upon, so just toss that onto a robot, cat or a fridge and you can buckle it. TODO: alot GOALS? Goals: Remove the hard requirement of keys from vehicles. Split key logic into a separate component. cars vehicles buckle to ian
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
labels
Jul 6, 2024
Acensti
changed the title
Vehiclemaybe
[dont merge] Buckle changes/rework incoming, Vehicle implemenation and proper keys functionality
Jul 6, 2024
SimpleStation14
changed the title
[dont merge] Buckle changes/rework incoming, Vehicle implemenation and proper keys functionality
[Dont Merge] Buckle Changes/Rework Incoming, Vehicle Implemenation and Proper Keys Functionality
Jul 6, 2024
Content.Server/Vehicles/UI/VehicleControlUI.cs |
DangerRevolution
added
Holy Shit
Priority: 3-Medium
Needs to be resolved at some point
Size: 2-Large
For large issues/PRs
Type: Feature
Creation of or significant changes to a feature
labels
Jul 6, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Closing due to inactivity, reopen if you ever return to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Sprite
Changes any png or json in an RSI
Changes: YML
Changes any yml files
Priority: 3-Medium
Needs to be resolved at some point
Size: 2-Large
For large issues/PRs
Status: Merge Conflict
FIX YOUR PR AAAGH
Type: Feature
Creation of or significant changes to a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the buckle system, splits keys into their own component, and implements a lightweight vehicle system as per wizden and my first PR and probably pathetic but i never coded for ss14 so i do apologize if you see horrendous mistakes just explain to me kindheartly why this is not good this is my first time at game dev in general that isnt unreal. I'm not done but i did do a lot of work which i just removed.
TODO
Media
Changelog
🆑