Mirror: Add Anti Anomaly Zone #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pspritechologist
added
the
Pull Request Mirror
Mnemotechnician
pushed a commit
to Mnemotechnician/Einstein-Engines
that referenced
this pull request
Sep 9, 2024
Rules Tweaks
Mnemotechnician
pushed a commit
to Mnemotechnician/Einstein-Engines
that referenced
this pull request
Sep 9, 2024
zelezniciar1
pushed a commit
to zelezniciar1/Einstein-Engines
that referenced
this pull request
Oct 30, 2024
<!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> <!-- The text between the arrows are comments - they will not be visible on your PR. --> ## About the PR <!-- What did you change in this PR? --> Admin stuff ## Why / Balance <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> Admin things ## Technical details <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> ## Media <!-- PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. Small fixes/refactors are exempt. Any media may be used in SS14 progress reports, with clear credit given. If you're unsure whether your PR will require media, ask a maintainer. --> ## Requirements <!-- Due to influx of PR's we require to ensure that PR's are following the correct guidelines. Please take a moment to read these if its your first time. Check the boxes below to confirm that you have in fact seen these (put an X in the brackets, like [X]): --> - [X] I have read and I am following the [Pull Request Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). I understand that not doing so may get my pr closed at maintainer’s discretion - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase ## Breaking changes <!-- List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. --> None, I hope **Changelog** <!-- Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog --> <!-- Make sure to take this Changelog template out of the comment block in order for it to show up. Changelog must have a 🆑 symbol, so the bot recognizes the changes and adds them to the game's changelog. 🆑 - add: Added fun! - remove: Removed fun! - tweak: Changed fun! - fix: Fixed fun! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror of PR-944: Add Anti Anomaly Zone from
DeltaV-Station/Delta-v
PR opened by
[rosieposieeee](https://github.com/rosieposieeee) at 2024-03-08 19:07:59 UTC PR merged by![width="16"/]()
[]() at 2024-03-17 13:35:52 UTC 7abdf9aPR changed 0 files with 0 additions and 0 deletions.
The PR had the following labels:
Original Body
About the PR
space-wizards/space-station-14#24634
Upstream added, then removed this, saying "Remove[d] mapping markers as everything should be ingame entities and this is functioning as an area." They left in the code for downstreams. While an ingame object that can perform this function might be useful, this would be best used for arrivals and inside the atmos gas chambers, to prevent those areas that are supposed to be ungriefed from getting griefed by the game itself. If it were an entity, people would probably game it and move those around, and if it were powered, it would fail at its target function. And regardless, upstream removed this without adding in that entity to replace it.
Additionally, some maps have areas where an anom could fully go crit without anyone noticing and it would never affect anybody... which is really boring, such as this area on arena. I have one or two areas like that on Submarine I'd like to use this for.