Revert "Random Announcer System (#415)"

[VMSolidus]

Description

This needed a little more time to cook, apparently it wasn't setting an announcer at all in the first place, and genuinely was just picking random sounds from random announcers.

[DEATHB4DEFEAT]

I'd rather a fix than revert, what exactly is the problem?

[VMSolidus]

I'd rather a fix than revert, what exactly is the problem?

The problem seems to be(at least from observation) that announcements are not correctly using Fallbacks, and are instead quite literally playing a random announcement from any announcer. The announcer could be Neil, and PirateRadioSpawnRule triggers(which does not, and should never have an announcement), which bafflingly sets off Michael's Code Blue alert. Or seemingly any announcement.

[DEATHB4DEFEAT]

I'd rather a fix than revert, what exactly is the problem?

The problem seems to be(at least from observation) that announcements are not correctly using Fallbacks, and are instead quite literally playing a random announcement from any announcer. The announcer could be Neil, and PirateRadioSpawnRule triggers(which does not, and should never have an announcement), which bafflingly sets off Michael's Code Blue alert. Or seemingly any announcement.

Weird, no idea how that happened, I'll look into it.

[VMSolidus]

I'd rather a fix than revert, what exactly is the problem?

The problem seems to be(at least from observation) that announcements are not correctly using Fallbacks, and are instead quite literally playing a random announcement from any announcer. The announcer could be Neil, and PirateRadioSpawnRule triggers(which does not, and should never have an announcement), which bafflingly sets off Michael's Code Blue alert. Or seemingly any announcement.

Weird, no idea how that happened, I'll look into it.

I appreciate it

[DEATHB4DEFEAT]

I'm not having any issues on master, is this a problem with DS?

[VMSolidus]

I'm not having any issues on master, is this a problem with DS?

image

It was originally reported by DS, but then I was able to reproduce it locally on an EE Master.

[DEATHB4DEFEAT]

I'm not having any issues on master, is this a problem with DS?

image

It was originally reported by DS, but then I was able to reproduce it locally on an EE Master.

Could you record the issue?

[DEATHB4DEFEAT]

Closing this in favor of #557.
Tell me if this should be reopened.