Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Anti Anomaly Zone #56

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add Anti Anomaly Zone #56

merged 1 commit into from
Apr 8, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #944: Add Anti Anomaly Zone from DeltaV-Station DeltaV-Station/Delta-v

PR opened by

rosieposieeee at 2024-03-08 19:07:59 UTC PR merged by

rosieposieeee at 2024-03-17 13:35:52 UTC

7abdf9a19fe59243201336e6b586ee4780a4722e

PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:

  • Changes: YML
  • Status: Needs Review

Original Body

About the PR

space-wizards/space-station-14#24634

Upstream added, then removed this, saying "Remove[d] mapping markers as everything should be ingame entities and this is functioning as an area." They left in the code for downstreams. While an ingame object that can perform this function might be useful, this would be best used for arrivals and inside the atmos gas chambers, to prevent those areas that are supposed to be ungriefed from getting griefed by the game itself. If it were an entity, people would probably game it and move those around, and if it were powered, it would fail at its target function. And regardless, upstream removed this without adding in that entity to replace it.

Additionally, some maps have areas where an anom could fully go crit without anyone noticing and it would never affect anybody... which is really boring, such as this area on arena. I have one or two areas like that on Submarine I'd like to use this for.

image

VMSolidus
VMSolidus approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy addition. No code modified.

@VMSolidus VMSolidus merged commit 5f500ea into Simple-Station:master Apr 8, 2024
11 checks passed
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Apr 12, 2024
@VMSolidus
Revert "Add Anti Anomaly Zone (Simple-Station#56)"
b6151b6 
This reverts commit 5f500ea.
SimpleStation14 pushed a commit that referenced this pull request Apr 13, 2024
@VMSolidus
Revert PR #56 through #76 (#104)
648fea3 
# Description

There was a miscommunication, and I bungled the repository during the
last round of merges. The Mirror Bot is not quite finished yet, and some
polishing needs to happen behind the scenes before we can actually start
doing this. Also new policies from the discord are pending regarding how
these PRs need to be handled. I'll need to either reopen or remake the
reverted PRs, since we do actually still need them. But we need PRs
mirrored from Wizards' Den in order to go through the list properly.


![image](https://github.com/Simple-Station/Einstein-Engines/assets/16548818/cb2df7ff-d85b-4653-93a2-d9001e99f175)
@Pspritechologist Pspritechologist added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Apr 23, 2024
@VMSolidus
Revert "Revert PR Simple-Station#56 through Simple-Station#76 (Simple…
42471e1 
…-Station#104)"

This reverts commit 648fea3.
VMSolidus added a commit that referenced this pull request May 5, 2024
@VMSolidus
Revert "Revert PR #56 through #76 (#104)" (#336)
2ccbdd3 
This reverts commit 648fea3.

# Description
Now that we have the list of Wizden Mirrors, it's now possible to bring
this back, and resume work on maintaining this repo.
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
@Fansana
Merge pull request Simple-Station#56 from FoxxoTrystan/scug-patch
5e16161 
Scug Patch
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
@Floof-Station-Bot
Automatic Changelog Update (Simple-Station#56)
3b0efe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimpleStation14 @VMSolidus @Pspritechologist @rosieposieeee