-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Hugs with Looking #563
Replace Hugs with Looking #563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer a tap or something, but this is fine.
You need to remove the sound effect.
hehe i forgor
hehe i forgor. It's gone now. |
Do you think you could also increase the interaction range of looking? |
I'm not certain how I'd do that, but that is a good idea. |
hugging-success-generic-target = { CAPITALIZE(THE($user)) } hugs you. | ||
looking-success-generic = You look at {THE($target)}. | ||
looking-success-generic-others = { CAPITALIZE(THE($user)) } looks at {THE($target)}. | ||
looking-success-generic-target = { CAPITALIZE(THE($user)) } looks at you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not override those. Create separate entries, but keep the old ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This + remove the hugging sound
And what if I want to hug a person and not awkwardly stare at them? |
you switch to emote and type it out |
Hugging is also used to make people stand up from a bed. Conventionally this is used to indicate to a patient "you are good to go". While hugging also doesn't make that much sense for that purpose, converting this to "looking" seems less so. Have you considered an alternative to this? SS14.Loader_QT2PLyiDuJ.mp4 |
Hugging isn't what's getting them out of the bed, it's unbuckling which existed before hugging was put into the game. A patient will hear the unbuckle sound and stand up all the same(you can also right click and go to unbuckle or drag them off). I understand that medical is absolutely starved for mechanics but this ain't it. |
Related to this, empty hand interact should either just look, or should have a different emote string, since it would be weird if just looking at someone unbuckled them. I'm in favor of the shoulder tap. |
Looking at someone isn't what's unbuckling them, it's simply left clicking on the person who's buckled into a chair or bed, this doesn't change the range at where this is possible either so I fail to see how this is 'weird'. If it seems strange to you, stop thinking 'looks at person, they unbuckle' being how it flows. Because this isn't how you seen it previously with hugging it's 'you look at the person, you unbuckle the person' they're separate things. Frankly I find it weird that my doctor is hugging me anyways??? What about literally every other situation, like security buckling someone out of bed/chair with cuffs? Random hug situations happen there, it's the same situation but with different department afterall. Changing the text from "hugs" to "looks at" just removes the weird behavior associated with having a dedicated hug prompt in the game, where you'll have folks across tables hug you, drive by hugs from mimes, trying to click on someone to attack them, trying to grab an item as someone walks over it, etc., with a far more generic prompt that fills more situations to reduce awkwardness and be less immersion breaking. (Shoulder tap doesn't do this, I'd even argue shoulder tap would cover less situations than hugs) The entire point of this PR is to be a very low scope, simple thing anyways, if you want added functionality or context specific interactions (I would love open hand on someone who has slipped to help them off the floor for instance) this is not within the scope of the PR. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I once again remind you that you should leave the old interaction strings as they were and add new ones below. Otherwise this will cause issues later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button, keep the old strings for use by other people and remove the hugging sound effect
oh shit I forgot I made this lol |
Description
Replaces the hugging action with the looking action. So that then when you click on someone, it says that you look at them rather than you hug them, and vice versa. It's awkward to accidentally hug people. Also ODJ told me to put this here instead of my downstream 😤
TODO
Media
Changelog
🆑