Refactor FabricateCandySystem Into Its Generic Equivalent #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
SimpleStation14
changed the title
DEATHB4DEFEAT
requested changes
Jul 19, 2024
DEATHB4DEFEAT
added
Priority: 4-Low
VMSolidus
previously requested changes
Jul 22, 2024
DEATHB4DEFEAT
approved these changes
Jul 23, 2024
|
|
||
| namespace Content.Shared.Actions.Events; | ||
|
|
||
| public sealed partial class FabricateActionEvent : InstantActionEvent |
There was a problem hiding this comment.
Suggested change
| public sealed partial class FabricateActionEvent : InstantActionEvent | |
| public sealed class FabricateActionEvent : InstantActionEvent |
There was a problem hiding this comment.
It's a DataDefinition so it needs to be partial
There was a problem hiding this comment.
Fuck, I accidentally applied the suggestion too... well, fuck me.
DangerRevolution
dismissed
VMSolidus’s stale review
moved from Nyano namespaces; review is STALE!!
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Mnemotechnican <[email protected]>
|
going to re-run this until no more unrelated test fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the nyano shitcode responsible for allowing borgs to dispense candies into a more generic variant, that allows to define what action dispenses what entity, and allowing an arbitrary number of such actions on an entity.
Requested by @DangerRevolution
Media
8mb.video-XtD-Kj7NIrga.mp4
Changelog
No cl no fun