Fix 125 Toolshed Commands Being Unusable for Anyone without +HOST

[Mnemotechnician]

Description

For reasons unknown, AdminManager has two command permission managers: _commandPermissions and _toolshedCommandPermissions. It used to load normal command permissions into the former, and toolshed command permissions into the latter. Since _toolshedCommandPermissions is NEVER actually used in checking whether a player can execute a command, all toolshed commands remained unavailable to anyone without +HOST.

This PR provides a bandaid fix for that: it makes it so that the same permissions are loaded into both managers at the same time. It's necessary to load them into _commandPermissions in order to allow regular players to execute them, and it's also necessary to load them into _toolshedCommandPermissions because otherwise the ToolshedManager will complain about those commands lacking permission flags.

This should also fixes some commands such as spawn, pos, comp being inaccessible to admins with +DEBUG and more.

Media

Admin-only commands are unaffected:

---

Changelog

🆑

• fix: Fixed toolshed command permissions. This will mostly affect admins who don't have full host access.

[DEATHB4DEFEAT]

For reasons unknown

Is math done by the server?

[Mnemotechnician]

Is math done by the server?

Supposedly so, although we can easily lock these commands behind +ADMIN if needed.

[DEATHB4DEFEAT]

Is math done by the server?

Supposedly so, although we can easily lock these commands behind +ADMIN if needed.

If the server is doing math it makes sense to restrict it.

[Mnemotechnician]

The thing is, this is a bug that prevented anyone without +HOST from using any commands listed in that file. I can add an admin flag to these commands if you want specifically that.

[Mnemotechnician]

Here.