Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore HoP As A Functional Job #576

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

VMSolidus
Copy link
Member

Description

By request from @OldDanceJacket, this PR does two things. First, it gives the HoP access to Cargo, so that in ODJ's own words, "The Hop can be like the Warden to Cargo. They are Brothers In Bureaucracy". The second thing this PR does is add BASIC department PDAs for each department to the PTECH vendor, enabling the HOP to hire people on as the basic roles for every department, with additional PDAs for the teaching roles(Interns).

By design, all specialized department roles(Such as Chemistry) cannot be granted by the HOP, and must instead be given by their respective heads of staff.

Media

image

Changelog

🆑

  • add: The Head Of Personnel can now hire people onto basic roles for each department by vending PDAs.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jul 22, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much bloat; dies of cringe

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in a lathe one day; this is cringe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that all of these items have a cargo sale value of zero, completely shocked me when I ran the Arbitration Test locally and it didn't complain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also surprised to see the test pass

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleasantly surprised to see this; a very unique solution to HoPcurity but allows them to still hire.

@OldDanceJacket OldDanceJacket merged commit e9bd710 into Simple-Station:master Jul 22, 2024
12 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants