Rename Fork Specific Options From "DeltaV" To "EinsteinEngines" #630
Conversation
github-actions
bot
added
Changes: C#
This goes back to the discussion about whether or not being able to cheaply opt out of species visions is okay or not. There's pros and cons to each side, but IMO it's for a different PR :) |
DangerRevolution
added
Size: 3-Medium
DangerRevolution
requested review from
VMSolidus,
Peptide90,
Pspritechologist,
OldDanceJacket and
NotScoutieBoi
|
Got it |
This reverts commit e977b7d.
|
My concession is that while yes it's important to have Accessibility Options, we currently don't have ANY other than the vision toggle(And most of the really good accessibility features require Harmony....), so can we move the button to one of the pre-existing tabs? Also, we can set that CVar to default to false. |
|
Personnally il say move the option to another tab, simply. |
|
Test fail valid |
|
I can rebase the branch to the current master branch then do the tab rename if we want. I can also remove the vision filter option as our traits cancel it out so the EE tab will be a placeholder for future additions. |
Leave the options, just rename the tab. |
FoxxoTrystan
added
Size: 5-Very Small
|
Whats the update on that PR? |
|
Closed since it's superceded by #928 |
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> This PR Remove and the DeltaV Option Tab while moving the specie filter to the general accessibility tab. View Media for images. This PR also Rebase the option and removed useless duplicated, CVars are moved, .ftl files. Tho cvar name is unchanged so the option will still be enable if you enabled it before. This PR fixes #481 and put PR #630 stale. --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>   </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - remove: DeltaV Option Tab (Options moved)
Fixes #481