Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zombie Improvements Take 2 #652

Merged

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Aug 2, 2024

Description

Problem: "Players like to stall zombie rounds"
Solution: Fix the Anti-Stall mechanic.

The set of functions for handling the automatic shuttle call now correctly only checks "The" station, rather than any grid containing a StationDataComponent. By using the less permissive _gameTicker.GetSpawnableStations(); function, the zombie gamerule no longer includes stations such as Centcomm, Planet Expeditions, some salvage wrecks, certain space ships, the Syndicate Listening Outpost, and Nukie World. Additionally, the check for "Healthy" humans no longer considers anyone infected with the zombie virus to be a "Healthy" human, ensuring that someone with a 200u jug of Bicaridine can no longer contribute to round stalling. Finally, dead (player)zombies are now by default checked for the purpose of calling the evac shuttle. The reason being for this assumption, is that dead zombies are still players removed from the round. If a majority of players are removed from the round(or fucked off to space), the shuttle should be called.

Changelog

🆑

  • fix: Zombie events have had their Anti-Stalling mechanic improved. Dead (Player) Zombies, Infected Players, and Initial Infected are all counted as zombies for the purpose of determine if the shuttle should be called. Additionally, any player who leaves the station is no longer counted as a healthy crewman for the automatic shuttle call.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Aug 2, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 2, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cl entry explains nothing about this PR

@VMSolidus
Copy link
Member Author

Cl entry explains nothing about this PR

Done.

@DangerRevolution DangerRevolution merged commit 0b0e5f3 into Simple-Station:master Aug 4, 2024
17 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants