Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Trait: Light Step #658

Merged
merged 15 commits into from
Aug 5, 2024

Conversation

angelofallars
Copy link
Contributor

@angelofallars angelofallars commented Aug 3, 2024

Description

Light Step is a 1-point Auditory trait that reduces the volume of your footsteps by roughly 50%, enabling you to be quieter and stealthier. Inspired by the SS13 trait of the same name.

TODO

  • Locale strings
  • Reduce the distance in which Light Step footsteps can be heard
    • It turns out that whatever I did reduced the delay between footstep sounds.
  • Discuss the balancing values for the trait

Technical details

In the current implementation, Light Step reduces the volume of footsteps by 10 dB, resulting in roughly halving the volume.

The fields in FootstepVolumeModifierComponent change the volume in terms of decibels.

Media

image

Changelog

🆑 Skubman

  • add: Add the Light Step trait, a 1-point trait that makes your footsteps quieter.

TODO: make the client controlling the Light Steps entity also hear
quieter footsteps instead of regular volume footsteps
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Aug 3, 2024
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Aug 4, 2024
@angelofallars angelofallars marked this pull request as ready for review August 4, 2024 02:01
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Felinids should most likely be disallowed from taking this trait. Felinids have NoShoesSilentFootstep comp; which means they walk silently with no shoes on. So this is just kind of redundant, when you can just take your shoes off.
  2. This should have a "heavystep" opposite, which makes it louder.
  3. Worth considering adding NoShoesSilentFootstep as it's own trait tbh. (IN A SEPERATE PR)

Copy link
Contributor

github-actions bot commented Aug 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Aug 4, 2024
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Aug 4, 2024
@angelofallars
Copy link
Contributor Author

  1. Felinids should most likely be disallowed from taking this trait. Felinids have NoShoesSilentFootstep comp; which means they walk silently with no shoes on. So this is just kind of redundant, when you can just take your shoes off.

    1. This should have a "heavystep" opposite, which makes it louder.

    2. Worth considering adding NoShoesSilentFootstep as it's own trait tbh. (IN A SEPERATE PR)

  1. Resolved with a9c62b0
  2. I tried testing out a louder volume, and it seems like they limit the maximum volume of sounds (for a very good reason), so the maximum volume footstep sound doesn't seem noticeably different to me compared to normal footsteps

@DangerRevolution DangerRevolution merged commit 0acb879 into Simple-Station:master Aug 5, 2024
16 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants