Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Trait: Sign Language #677

Merged

Conversation

angelofallars
Copy link
Contributor

@angelofallars angelofallars commented Aug 5, 2024

Description

Sign Language is a 1-point Visual trait that allows you to use Galactic Sign Language.

Media

image

image

Changelog

🆑 Skubman

  • add: Add a new 1-point trait called Sign Language, a trait that allows you to communicate in Galactic Sign Language.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Aug 5, 2024
@angelofallars angelofallars marked this pull request as ready for review August 5, 2024 15:05
@DangerRevolution
Copy link
Contributor

This should probably also be reused for foreigner tbh; and just have translators in Loadouts but that's a wyci

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't add the trait to mute.

@angelofallars
Copy link
Contributor Author

angelofallars commented Aug 5, 2024

This doesn't add the trait to mute.

Mute and Sign Language should be separate, as when you're a Mute you can still communicate with other methods, namely papers, and also Natural Telepath giving you access to telepathic chat.

Also, the points given by Mute are enough to buy Sign Language.

@DangerRevolution
Copy link
Contributor

This doesn't add the trait to mute.

Mute and Sign Language should be separate, as when you're a Mute you can still communicate with other methods, namely papers, and also Natural Telepath giving you access to telepathic chat.

@DangerRevolution DangerRevolution added Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature labels Aug 5, 2024
mainly to prevent merge conflicts if Simple-Station#670 or Simple-Station#676 gets merged first
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally.

@VMSolidus VMSolidus merged commit 17aca3c into Simple-Station:master Aug 5, 2024
11 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 5, 2024
@FoxxoTrystan
Copy link
Member

Me lazy so someone else does it, nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants