Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamina Damage Resistance Real #679

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

whateverusername0
Copy link
Contributor

Description

Added stamina damage resistance, acts the same way as armor does.
Call this shock resistance if you wish :trollface:
Just attach StaminaDamageResistance component to an entity with a set multiplier and have fun.

Made all hardsuits 25% stun resistant by default.
With some variety, e.g. nukie, ERT, captain, HoS suits are 50%, DS are 90%, etc. etc.

This will not remove stuneta but it will make it more difficult to stamcrit a traitor or such.

Some armor/batong ratios that you need to hit before the target is stamcritted:
0% - 3 batong hits
25% - 4 batong hits
50% - 6 batong hits
75% - 12 batong hits
90% - 28 batong hits :trollface:
100% -
image

Changelog

🆑

  • add: Added different stamina damage resistance to hardsuits.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Aug 6, 2024
@SimpleStation14 SimpleStation14 changed the title Stamina damage resistance real Stamina Damage Resistance Real Aug 6, 2024
@whateverusername0 whateverusername0 marked this pull request as draft August 6, 2024 04:31
whateverusername0 added 2 commits August 6, 2024 14:40
@VMSolidus
Copy link
Member

image
I would like to let you know that this basically completely breaks those three systems by the way. They are increasing outbound stamina damage, and are dependent on having an event that links to outbound stamina damage.

@VMSolidus
Copy link
Member

Nevermind, carry on.
image

@whateverusername0 whateverusername0 marked this pull request as ready for review August 6, 2024 05:12
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 6, 2024
@DangerRevolution DangerRevolution added Priority: 2-High Needs to be resolved as soon as possible Holy Shit Size: 2-Large For large issues/PRs Type: Feature Creation of or significant changes to a feature Type: Rework Large changes to a system, like a mix between the Balancing, Codebase, and Respace labels and removed Status: Needs Review Someone please review this labels Aug 6, 2024
@DangerRevolution
Copy link
Contributor

Does it stack if you have multiple equipped?

@whateverusername0
Copy link
Contributor Author

Does it stack if you have multiple equipped?

works just like normal armor but for stamina damage
so yes

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would want to le playtest it but this is a code approval

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been watching the playtests of it, this is pretty great! Thanks for also addressing the three instances we have of Nyano legacy code. I apologize you had to run into those. I still have my work cutout for me with refactoring the lot of them.

@VMSolidus VMSolidus merged commit 55aa822 into Simple-Station:master Aug 6, 2024
25 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Holy Shit Priority: 2-High Needs to be resolved as soon as possible Size: 2-Large For large issues/PRs Type: Feature Creation of or significant changes to a feature Type: Rework Large changes to a system, like a mix between the Balancing, Codebase, and Respace labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants