Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates WelderRefinable Component #687

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

BlueHNT
Copy link
Contributor

@BlueHNT BlueHNT commented Aug 6, 2024

Description

I have made this originally for N14 as there was a heavy need for junk items to be list instead of a hash. It created a few issues where you were unable to put down 2 pieces of steel without making a new defined entity which spawns a stack of 2.
I thought this was quite annoying so I decided to instead make it into a EntitySpawnEntry from a string which would also give it options of amount prob maxAmount and orGroup which would definitely aid in the scrapping needs there as you could randomize the refined amounts.

I believe this could be useful upstream. As well as cleaning up code which is more modifiable than before.

The new example of how it can be typed in yaml is also simpler in my opinion as it is self-explanatory and used in various places like StorageFill contents for one.

  - type: WelderRefinable
    refineResult:
    - id: SheetGlass1
      amount: 1
      maxAmount: 2
      prob: 0.5
      orGroup: Glass

🆑
refactor: Refactors WelderRefinableComponent.cs and RefiningSystem.cs
tweak: Tweaked the formatting for WelderRefinable refineResult to use EntitySpawnEntry format

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Aug 6, 2024
@SimpleStation14 SimpleStation14 changed the title Updates WelderRefinable component Updates WelderRefinable Component Aug 6, 2024
@DangerRevolution DangerRevolution requested a review from a team August 7, 2024 23:38
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 7, 2024
@OldDanceJacket OldDanceJacket merged commit e9e10f2 into Simple-Station:master Aug 8, 2024
12 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants