-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loadouts V3 #736
Loadouts V3 #736
Conversation
they don't work for some reason, will fix later
also fix empty tabs being shown and the style class being bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8mb.video-nf0-2JsAcOsG.mp4
This isn't a proper review yet, I am merely noting it here that I have verified through ingame testing(video provided) that this PR works as advertised. I will however need to go over this with a fine toothed comb, and also make my PR-PR that changes CowToolbox to serve as the "Extreme OR XOR shitton of new loadout requirements" testing tool, and also demonstrate to would-be-yml-contributors how the new system works.
but still keep my absurd changes from before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this small change.
{ | ||
if (!_tabs.TryGetValue(control, out var button)) | ||
return; | ||
|
||
if (button is Button b) | ||
b.Text = title; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
if (!_tabs.TryGetValue(control, out var button)) | |
return; | |
if (button is Button b) | |
b.Text = title; | |
} | |
{ | |
if (!_tabs.TryGetValue(control, out var button) | |
|| button is not Button b) | |
return; | |
b.Text = title; | |
} |
Description
Resolves #723
Resolves #708
Resolves #691
Resolves #671
Resolves #643
Adding/removing loadouts and categories (and trait stuff) will require disconnecting and reconnecting to the server (or anything that will reload the lobby UI) due to how I've done my caching.
TODO
Exclusive
Media
New loadouts/traits UI
NeoTabContainer allows changing the tab orientation
https://youtu.be/krg8TJoQG3I
Changelog
🆑