Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Playing Multiple Announcement Sounds at Once #740

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Allow Playing Multiple Announcement Sounds at Once #740

merged 1 commit into from
Aug 22, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

Description

@VMSolidus said he had issues with SuperMatter announcements not playing correctly.

Media

8mb.video-wMA-ZFj5LV94.mp4

Changelog

🆑

  • fix: Announcements can play multiple sounds now (you can revert to the old behavior in sound setting if you want though)

@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small labels Aug 17, 2024
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files labels Aug 17, 2024
@SimpleStation14 SimpleStation14 changed the title allow playing multiple announcement sounds at once Allow Playing Multiple Announcement Sounds at Once Aug 17, 2024
@VMSolidus VMSolidus merged commit 4f09464 into Simple-Station:master Aug 22, 2024
17 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 22, 2024
@SimpleStation14
Automatic Changelog Update (#740)
2eda261
@Darkmajia Darkmajia mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

@Peptide90 Peptide90 Awaiting requested review from Peptide90

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket

Assignees

@DEATHB4DEFEAT DEATHB4DEFEAT

Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DEATHB4DEFEAT @VMSolidus @DangerRevolution