Add LocalizedPrototype Type #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEATHB4DEFEAT
added
Priority: 3-Medium
github-actions
bot
added
Status: Needs Review
Pspritechologist
previously requested changes
Aug 18, 2024
VMSolidus
approved these changes
Aug 21, 2024
FoxxoTrystan
approved these changes
Sep 17, 2024
Mnemotechnician
suggested changes
Sep 19, 2024
Comment on lines
+14
to
+16
| public string NameLoc => ToLocalizationString("name"); | ||
| /// <summary>The localized string for the name of prototype</summary> | ||
| public string Name => Loc.GetString(NameLoc); |
There was a problem hiding this comment.
This recalculates NameLoc every time either of those properties is accessed, which is bad. It should be cached and only calculated once (perhaps as a deserialization hook, or a lazily evaluated/cached property?)
| // Lowercase the first letter | ||
| type = char.ToLowerInvariant(type[0]) + type[1..]; | ||
| // Replace every uppercase letter with a dash and the lowercase letter | ||
| type = type.Aggregate("", (current, c) => current + (char.IsUpper(c) ? "-" + char.ToLowerInvariant(c) : c.ToString())); |
There was a problem hiding this comment.
This performs n string concatenations, each concatenation having a cost of n itself, resulting in an O(n²) operation. This should use a StringBuilder instead. Considering that this function will be called hundreds or thousands of times, performance matters here.
|
This PR is approved but is it still going forward? |
FoxxoTrystan
added
Status: Awaiting Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new Type for Prototypes to inherit instead of IPrototype with standard localization formats and lambda shortcuts to them.