Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagonal Window Smoothing #805

Merged

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Aug 26, 2024

Description

Diagonal windows weren't updated to use the new smoothing when we added a bunch of new sprites designed around connected textures. This PR fixes that for all diagonal windows.

image

Changelog

🆑

  • add: Diagonal windows now use connected textures.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Aug 26, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 26, 2024
@DangerRevolution DangerRevolution added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point Changes: Sprite Changes any png or json in an RSI Type: Feature Creation of or significant changes to a feature Type: Cleanup Like Rework but small and removed Status: Needs Review Someone please review this labels Aug 26, 2024
@FoxxoTrystan
Copy link
Member

FoxxoTrystan commented Aug 27, 2024

Why i did not do this if i remember is that its does not fit well with walls if i remember.

@VMSolidus
Copy link
Member Author

Why i did not do this if i remember is that its does not fit well with walls if i remember.

image

It actually looks fine, genuinely any issue with diagonal windows not fitting well with walls is a mapper "Skill Issue"
However they look AWFUL without the connected textures. Hence me absolutely wanting this update.

@VMSolidus
Copy link
Member Author

image

Also, diagonal grills exist, and something like this looks absolutely PEAK.

@github-actions github-actions bot removed the Changes: Sprite Changes any png or json in an RSI label Aug 27, 2024
@VMSolidus VMSolidus merged commit 1a1392c into Simple-Station:master Sep 1, 2024
11 checks passed
SimpleStation14 added a commit that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Type: Cleanup Like Rework but small Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants