Make Height Sliders Affect Your Bloodstream Volume #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
SimpleStation14
changed the title
VMSolidus
reviewed
Sep 5, 2024
Co-authored-by: VMSolidus <[email protected]> Signed-off-by: Mnemotechnican <[email protected]>
DEATHB4DEFEAT
approved these changes
Sep 8, 2024
Content.Server/HeightAdjust/BloodstreamAffectedByMassComponent.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Mnemotechnican <[email protected]>
SimpleStation14
added a commit
that referenced
this pull request
Sep 8, 2024
VMSolidus
pushed a commit
that referenced
this pull request
Sep 12, 2024
# Description With #858 (Make Height Sliders Affect Your Bloodstream Volume) being merged, it introduced variable blood volumes for differing sizes, whereas before everyone had the same blood volume (300u). Because Blood Deficiency subtracted a flat amount from the bloodstream, it resulted in an unintended consequence where small characters died very quickly due to blood loss, while large characters could live for hours. This makes the blood loss amount of Blood Deficiency a **percentage** of the entity's max blood volume, which means that the time to become low blood is now the same regardless of blood volume. # Changelog :cl: Skubman - fix: Blood Deficiency now makes you lose a consistent percentage of blood regardless of your blood volume, which is dictated by size. This makes the time to low blood and death consistent for every character of all sizes with this trait.
Remuchi
pushed a commit
to WWhiteDreamProject/wwdpublic
that referenced
this pull request
Oct 19, 2024
# Description With Simple-Station/Einstein-Engines#858 (Make Height Sliders Affect Your Bloodstream Volume) being merged, it introduced variable blood volumes for differing sizes, whereas before everyone had the same blood volume (300u). Because Blood Deficiency subtracted a flat amount from the bloodstream, it resulted in an unintended consequence where small characters died very quickly due to blood loss, while large characters could live for hours. This makes the blood loss amount of Blood Deficiency a **percentage** of the entity's max blood volume, which means that the time to become low blood is now the same regardless of blood volume. # Changelog :cl: Skubman - fix: Blood Deficiency now makes you lose a consistent percentage of blood regardless of your blood volume, which is dictated by size. This makes the time to low blood and death consistent for every character of all sizes with this trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Something that just makes sense, this makes your effect character weight affect your bloodstream volume. As a minimum size felinid you will get 33% of normal blood volume, whereas as something as huge as a lamia you may get up to 3 times the normal blood volume.
The resulting volume of your bloodstream can be calculated as
V = clamp(normal_volume * mass_contest ^ 0.6)(assuming default parameters), where mass_contest is the result of a mass contest between your entity and the average humanoid. For average species like vulps, this means that their bloodstream can become up to ~40% smaller than normal (at minimum size), or up to 50% larger than normal (at maximum size). For onis the range is shifted towards higher values, a maximum size oni will have twice as much blood as an average human.This has both drawbacks and advantages. For instance, having little blood means you can bleed out easily, but at the same time it means it will take way less blood packs/saline/iron/proteins to restore your blood to the normal level. Opposite is also true, having more blood means you will be harder to heal.
Also, this PR slightly refactors the HeightAdjustSystem to be more flexible.
Media
8mb.video-ZJZ-xcwgAzX7.mp4
Changelog
🆑