Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Justice Department #867

Closed
wants to merge 3 commits into from

Conversation

Elijahrane
Copy link
Contributor

Description

Removes the justice department.

Changelog

🆑 Rane

  • remove: Removed the Justice Department.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Sep 6, 2024
@SimpleStation14 SimpleStation14 changed the title remove the justice department Remove the Justice Department Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

RSI Diff Bot; head commit 6d15103 merging into 93e3ba6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Ears/Headsets/justice.rsi

State Old New Status
alt-equipped-EARS Removed
equipped-EARS Removed
icon Removed
icon_alt Removed

Resources/Textures/DeltaV/Interface/Misc/job_icons.rsi

State Old New Status
ChiefJustice Removed
Clerk Removed
Lawyer Removed
Prosecutor Removed

Resources/Textures/DeltaV/Markers/jobs.rsi

State Old New Status
chiefjustice Removed
clerk Removed
prosecutor Removed

Resources/Textures/DeltaV/Objects/Devices/encryption_keys.rsi

State Old New Status
justice_label Removed

Resources/Textures/DeltaV/Objects/Devices/pda.rsi

State Old New Status
pda-chiefjustice Removed
pda-clerk Removed
pda-prosecutor Removed

Resources/Textures/DeltaV/Objects/Misc/stamps.rsi

State Old New Status
stamp-cj Removed
stamp-notary Removed

Resources/Textures/DeltaV/Structures/Doors/Airlocks/Glass/justice.rsi

State Old New Status
assembly Removed
bolted_unlit Removed
closed Removed
closed_unlit Removed
closing Removed
closing_unlit Removed
deny_unlit Removed
emergency_unlit Removed
open Removed
opening Removed
opening_unlit Removed
panel_closing Removed
panel_open Removed
panel_opening Removed
sparks Removed
sparks_broken Removed
sparks_damaged Removed
sparks_open Removed
welded Removed

Resources/Textures/DeltaV/Structures/Doors/Airlocks/Standard/justice.rsi

State Old New Status
assembly Removed
bolted_unlit Removed
closed Removed
closed_unlit Removed
closing Removed
closing_unlit Removed
deny_unlit Removed
emergency_unlit Removed
open Removed
opening Removed
opening_unlit Removed
panel_closing Removed
panel_open Removed
panel_opening Removed
sparks Removed
sparks_broken Removed
sparks_damaged Removed
sparks_open Removed
welded Removed

Resources/Textures/DeltaV/Structures/Wallmounts/signs.rsi

State Old New Status
direction_justice Removed

Resources/Textures/Structures/Storage/closet.rsi

State Old New Status
cj Removed
cj_door Removed
cj_open Removed
clerk Removed
clerk_door Removed
clerk_open Removed

Edit: diff updated after 6d15103

@ShatteredSwords
Copy link
Contributor

The whole point of porting Justice was so EE could port stuff from Delta without any issues 🙃

@gluesniffler
Copy link
Contributor

based

Resources/Migrations/eeMigration.yml Outdated Show resolved Hide resolved
@Flybik
Copy link
Contributor

Flybik commented Sep 6, 2024

I then propose to immediately remove all roles except engineers and force them to build the station during their shift. 😡

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Sep 14, 2024
@FoxxoTrystan FoxxoTrystan added Size: 3-Medium For medium issues/PRs Status: Needs Discussion Must be discussed labels Sep 17, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, DEATHB4DEFEAT and Pspritechologist and removed request for a team September 17, 2024 19:10
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Sep 17, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, FoxxoTrystan, Peptide90 and OldDanceJacket and removed request for a team September 25, 2024 22:32
@FoxxoTrystan FoxxoTrystan added the Priority: 3-Medium Needs to be resolved at some point label Sep 25, 2024
@FoxxoTrystan
Copy link
Member

Is this PR still getting worked on?

@Elijahrane
Copy link
Contributor Author

Presumably I'm supposed to be repobanned so I never bothered to check

@FoxxoTrystan
Copy link
Member

Presumably I'm supposed to be repobanned so I never bothered to check

Huh? wha?
@VMSolidus ?

@VMSolidus
Copy link
Member

Presumably I'm supposed to be repobanned so I never bothered to check

I literally don't have the ability to repoban people. I also don't care to repoban people unless they're doing something ridiculous like making a PR that replaces every word in the entire repo with a racial slur.

@Elijahrane
Copy link
Contributor Author

Well I'm not really interested in finishing this PR but I may have something to contribute at a later date, who knows

@Elijahrane Elijahrane closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants