Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical Pulling #883

Merged

Conversation

Mnemotechnician
Copy link
Contributor

@Mnemotechnician Mnemotechnician commented Sep 7, 2024

Description

Fixes pulling being obnoxiously unphysical. Entities now exert a specific amount of force defined as the product of their mass and the SpecificForce set in their PullerComponent. Doing a ctrl-right click now sets a target position where your entity begins to continuously push the pulled entity towards, instead of throwing it or pushing it once (however, it should still be possible to drag people and disposals and the like). Additionally, your entity will properly experience recoil from dragging someone around.

TODO

  • Do stuff
  • Fix stuff
  • Fix aghosts not being able to push (?)
  • Fix pulling giving you free kinetic energy while in spess (how?)
  • Test if throwing felinids into disposals via pulling still works :trollface:

Media

8mb.video-TL6-eZoRVW8g.mp4

Changelog

🆑

  • add: Pulling has been reworked. Your character will now try to continuously push the pulled entity when you use the push keybind.
  • remove: You can no longer push the pulled entity while walking, and pushing now follows the momentum conservation laws.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Sep 7, 2024
@SimpleStation14 SimpleStation14 changed the title Physical pulling Physical Pulling Sep 7, 2024
@Mnemotechnician
Copy link
Contributor Author

This wostly morks now, so marking as ready to review.

8mb.video-F8s-3kFnIcbI.mp4

@Mnemotechnician Mnemotechnician marked this pull request as ready for review September 12, 2024 17:22
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Sep 17, 2024
@FoxxoTrystan FoxxoTrystan added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point labels Sep 17, 2024
Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleasae update the description and CL.

@Mnemotechnician
Copy link
Contributor Author

I forgot

@VMSolidus VMSolidus merged commit 5004cf8 into Simple-Station:master Sep 17, 2024
29 checks passed
SimpleStation14 added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants