-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physical Pulling #883
Merged
VMSolidus
merged 3 commits into
Simple-Station:master
from
Mnemotechnician:feat/phsyical-pulling
Sep 17, 2024
Merged
Physical Pulling #883
VMSolidus
merged 3 commits into
Simple-Station:master
from
Mnemotechnician:feat/phsyical-pulling
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
labels
Sep 7, 2024
This wostly morks now, so marking as ready to review. 8mb.video-F8s-3kFnIcbI.mp4 |
FoxxoTrystan
requested review from
VMSolidus,
FoxxoTrystan and
DEATHB4DEFEAT
September 17, 2024 19:03
FoxxoTrystan
added
Size: 3-Medium
For medium issues/PRs
Priority: 3-Medium
Needs to be resolved at some point
labels
Sep 17, 2024
FoxxoTrystan
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pleasae update the description and CL.
I forgot |
FoxxoTrystan
approved these changes
Sep 17, 2024
VMSolidus
approved these changes
Sep 17, 2024
SimpleStation14
added a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
Priority: 3-Medium
Needs to be resolved at some point
Size: 3-Medium
For medium issues/PRs
Status: Needs Review
Someone please review this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes pulling being obnoxiously unphysical. Entities now exert a specific amount of force defined as the product of their mass and the SpecificForce set in their PullerComponent. Doing a ctrl-right click now sets a target position where your entity begins to continuously push the pulled entity towards, instead of throwing it or pushing it once (however, it should still be possible to drag people and disposals and the like). Additionally, your entity will properly experience recoil from dragging someone around.
TODO
Media
8mb.video-TL6-eZoRVW8g.mp4
Changelog
🆑