Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shoukou atmos rework and tweaks #89

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #1049: shoukou atmos rework and tweaks from DeltaV-Station DeltaV-Station/Delta-v

PR opened by

deltanedas at 2024-04-02 12:59:18 UTC PR merged by

deltanedas at 2024-04-03 02:10:51 UTC

1f515677f52899db3453c2beacd0c3fe93100904


PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:

  • Status: Needs Review
  • Changes: Map

Original Body

About the PR

mostly started as getting a good gas recycler setup, but now has all atmos aspects of shoukou improved

  • since thermomachines are really slow it both takes years for the co2 to heat up and the o2 to cool down. so i made it use teg burn chamber for heat and a radiator array for cooling the oxygen from epic temperatures. it makes lots of oxygen and is easy to control it
  • teg is now good similar to submarine
  • made teg and smes share smeses and renamed them main/aux to reflect this (with ame off 3 would be empty 2 would be full)
  • removed the annoying catwalks, unnecessary pipes and mixers but still having outlets. nobody is going to use that for trit anyway. if you want to filter nitrogen etc (you should never do this) theres steel sheets to do that or whatever else you want.
  • plasma chamber has an injector like all the others so you can filter that since its the only gas you should actually filter
  • epi has proper atmos controls now
  • chef freezer uses passive vent for cooling air vent for pressure
  • med finally has exit button

Media

teg
16:56:12

recycler + stuff
16:56:30

epi atmos
16:57:30

Changelog
🆑

  • tweak: Reworked Shoukou's atmospherics setup. The Gas Recycler is now usable among other things.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Apr 8, 2024
@Pspritechologist Pspritechologist added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 10, 2024
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Apr 14, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:14
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label May 5, 2024
Copy link
Contributor

github-actions bot commented May 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@VMSolidus VMSolidus marked this pull request as ready for review May 9, 2024 03:30
@VMSolidus VMSolidus closed this May 11, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
zelezniciar1 pushed a commit to zelezniciar1/Einstein-Engines that referenced this pull request Oct 30, 2024
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

I fixed my oops for the scheduler (typo)

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Changed scheduler name to normal
---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Typo

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![Example Media Embed](https://example.com/thisimageisntreal.png)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: TheGreenChkrta
add: Added dungeo-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Status: Merge Conflict FIX YOUR PR AAAGH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants