Reimplement Part Upgrading #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loot spawner (#23752)" This reverts commit 9d047a7.
github-actions
bot
added
Changes: C#
|
Time to go watch the tests fail and make me go back digging through the code again. |
|
86 files changed |
DEATHB4DEFEAT
previously requested changes
Sep 18, 2024
Content.IntegrationTests/Tests/Construction/Interaction/MachineConstruction.cs
Outdated
Show resolved
Hide resolved
Content.IntegrationTests/Tests/Construction/Interaction/MachineConstruction.cs
Outdated
Show resolved
Hide resolved
Content.IntegrationTests/Tests/Construction/Interaction/MachineConstruction.cs
Outdated
Show resolved
Hide resolved
Content.IntegrationTests/Tests/Construction/Interaction/MachineConstruction.cs
Outdated
Show resolved
Hide resolved
Content.IntegrationTests/Tests/Interaction/InteractionTest.Constants.cs
Outdated
Show resolved
Hide resolved
Resources/Locale/en-US/construction/components/machine-part-component.ftl
Outdated
Show resolved
Hide resolved
Resources/Locale/en-US/singularity/components/emitter-component.ftl
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Markers/Spawners/Random/salvage.yml
Outdated
Show resolved
Hide resolved
OldDanceJacket
approved these changes
Sep 18, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>
…olidus/Einstein-Engines into Revert-Upgrade-Part-Removals
Peptide90
approved these changes
Sep 21, 2024
SimpleStation14
added a commit
that referenced
this pull request
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By extremely popular demand(Both internally, and from our downstreams), this PR reimplements Part Upgrading. Since some of the systems that this PR touches were substantially changed since the removal of Parts, I had to do a lot of very in depth by-hand edits of individual systems. Shockingly, the only one that really proved any trouble was Cloning System, so I'm genuinely surprised wizden didn't substantially touch any of these codes since removing parts..
Changelog
🆑