-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harpy Flight System #919
Merged
Merged
Harpy Flight System #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Audio
Changes any ogg files
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: Sprite
Changes any png or json in an RSI
Changes: YML
Changes any yml files
labels
Sep 14, 2024
Love this! Excited to see how this enhances gameplay! Birb |
VMSolidus
requested changes
Sep 14, 2024
Co-authored-by: VMSolidus <[email protected]> Signed-off-by: gluesniffler <[email protected]>
Co-authored-by: VMSolidus <[email protected]> Signed-off-by: gluesniffler <[email protected]>
Co-authored-by: VMSolidus <[email protected]> Signed-off-by: gluesniffler <[email protected]>
VMSolidus
approved these changes
Sep 16, 2024
OldDanceJacket
approved these changes
Sep 16, 2024
SimpleStation14
added a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: Audio
Changes any ogg files
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: Sprite
Changes any png or json in an RSI
Changes: YML
Changes any yml files
Status: Needs Review
Someone please review this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a generic system which gives an entity the ability to fly. Optionally increasing their speed in exchange for a continuous stamina drain, which can, and will stamcrit them if left unchecked.
Technical Details?
We normally dont have this section but I'd like to outline the changes since I messed with quite a few systems:
FlightComponent
which can be added to any entity in YML, needs to be tied to an action with an event of typeToggleFlightEvent
This component holds properties for:FlyingVisualizerSystem
that can take a givenAnimationKey
which points to a shader, and optionally can apply it to either the entire sprite, or a given layer.SharedGravitySystem
for making the entity weightless when it has theFlightComponent
and is flying.SharedCuffableSystem
to disable cuffing when the target has theFlightComponent
and is flying.StaminaComponent
which serves as a dictionary for persistent drains, with the key being the source (UID) of where it came from. The drains can also indicate if they should apply the stamina slowdown or not (relevant for both this PR, and for an eventual sprinting PR)Media
Changelog
🆑 Mocho