-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port] StepTriggerGroup From WhiteDream #929
[Port] StepTriggerGroup From WhiteDream #929
Conversation
…mple-Station#53) * Ipc modifier added * StepTriggerGroup prototype and change in system. * fix change chemistry_effects.yml * types added in trigger/immunity * comments/clean * minor fix * another small fix * proto id / mouse landmine fix * CleanCode optimization + fixes * final * fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diona need glass immunity (and slip but they already got (noslips).
infact, should noslip shoses just have also whitelists?
Resources/Prototypes/Nyanotrasen/Entities/Mobs/Species/felinid.yml
Outdated
Show resolved
Hide resolved
Noslip is its own separate thing, and Diona have it. Also Diona have ShoesRequiredStepTriggerImmune so they don't care about glass. |
Co-authored-by: FoxxoTrystan <[email protected]> Signed-off-by: VMSolidus <[email protected]>
Also that is some cursed CL |
Yep lol. But when porting from another codebase, we are supposed to preserve the original CL. I kinda like how they do it with bilingual changes. :) |
its funny and i understood it so, okay! |
Do the CL as is normally done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not stale, please provide this to Dionas.
Before they had a special component or tag, witcth may got removed with the time, but again they are wood, sshould not be affected by glass.
- type: StepTriggerImmune
whitelist:
types:
- Shard
Done |
Description
This is a port of WWhiteDreamProject/wwdpublic#53 from White Dream. This PR improves the StepTriggerImmune component by making it operate on a more granular Blacklist system, such that StepTriggerImmune entities can further clarify via prototypes which kinds of floor traps they are immune to, such as landmines/mousetraps, and not have blanket immunity to everything. Because it turns out things like Lava and Soap also were caught by the immunity, when really we just wanted Harpies & Felinids to not trigger landmines.
Media
Changelog
🆑 Hell_Cat
Feature: StepTriggerSystem has been improved with new StepTriggerGroups. Additionally, the StepTriggerImmune component now allows declaring for specific StepTriggerGroups for a given entity to be immune to. Some examples may be, Felinids, Mice, and Harpies being unable to set off Landmines.