NyanoCombat Part 4: MeleeSystem Refactor Part 2, Electric Boogaloo #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMSolidus
added
Holy Shit
Priority: 3-Medium
OldDanceJacket
approved these changes
Sep 19, 2024
FoxxoTrystan
approved these changes
Sep 20, 2024
| @@ -49,6 +50,7 @@ public abstract class SharedMeleeWeaponSystem : EntitySystem | |||
| [Dependency] private readonly IPrototypeManager _protoManager = default!; | |||
| [Dependency] private readonly StaminaSystem _stamina = default!; | |||
| [Dependency] private readonly ContestsSystem _contests = default!; | |||
| [Dependency] private readonly IConfigurationManager _config = default!; | |||
There was a problem hiding this comment.
Why is this added if not used, just asking.
There was a problem hiding this comment.
Probably a leftover from when the Contest Constructor lived in a Partial of SharedMeleeWeaponSystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Surprise motherfucker, here's a massive fucking refactor of SharedMeleeWeaponSystem.
The MeleeWeaponComponent now allows for melee weapons to directly configure how and what members of the ContestsSystem they wish to utilize for influencing damage. Additionally, the damage of a melee weapon modified by Contests is now also visible when examined(Although this only reflects damage as per the current condition of the user).
Changelog
🆑