Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Language Menu #936

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Conversation

VMSolidus
Copy link
Member

Description

This is a very early take on a Language menu, making use of the new CharacterItemGroups functionality, as well as functionality added to the trait system that allows it to add and remove languages directly. This PR adds in the languages Tau-Cetic Basic(taking the place of Galactic Common), Tradeband, Freespeak, Elyran Standard, and Sol Common(I'm replacing the extremely basic bastardized Sol Common we had before with the fully realized version of it from Bay12).

Media

image

Changelog

🆑

  • add: A basic Languages menu has been added into the Traits tab.
  • add: Tau-Ceti Basic, Tradeband, Freespeak, Elyran Standard, Sol Common, and Sign Language have been added to the Languages tab.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Sep 20, 2024
@DEATHB4DEFEAT
Copy link
Member

DEATHB4DEFEAT commented Sep 20, 2024

should do
>mental
>>uncatgorized (or some)
>>language

@VMSolidus
Copy link
Member Author

should do >mental >>uncatgorized (or some) >>language

Actually it should probably be a subcategory of Speech. Along with Accents as another subcategory.

@FoxxoTrystan
Copy link
Member

Please do not change the default GC Languages, this is the more easy for anyone to understand what its is, anything "lore" or dunno related should be choosen by servers not in base EE.

So BY GOD, dod not replace GC, even the Tau-Cetic yml file should NOT have a color if default.

@FoxxoTrystan FoxxoTrystan added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point labels Sep 20, 2024
@FoxxoTrystan
Copy link
Member

Tho characterItemGroup is cool, that i can agree.

@VMSolidus
Copy link
Member Author

Please do not change the default GC Languages, this is the more easy for anyone to understand what its is, anything "lore" or dunno related should be choosen by servers not in base EE.

So BY GOD, dod not replace GC, even the Tau-Cetic yml file should NOT have a color if default.

No. GC is getting replaced specifically because it's a Joke language, and the new one replacing it has actual syllable structures that make it "sound" like real words someone would actually stay instead of "WOOBY GUBB BAZOOP". When I get syllable structures for the remaining languages, they're getting un-joked as well. Having GC in this codebase is kinda unacceptable.

@VMSolidus
Copy link
Member Author

image

Having Second-Person text in these is also unacceptable. I went ahead and removed the default color from TCB, and also fixed Sign Language awfullness by removing the genuinely terrible replacements.

Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if you wana remove GC, please do it correctly.

Regardning Languages.yml folder, please avoid making multiple variations, just regroup it in one languages.yml file or seperate them like you did but also those in languages.yml

example animals.yml can be their own thing.
Right now slightly, its a tiny mess.

Also is it possible to to edit MaxItems on characterItemGroup with a trait?

Resources/Locale/en-US/language/languages.ftl Show resolved Hide resolved
Resources/Prototypes/Language/elyran.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Language/freespeak.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Language/languages.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Language/solcommon.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Language/taucetibasic.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Language/tradeband.yml Outdated Show resolved Hide resolved
@VMSolidus
Copy link
Member Author

Fine if you wana remove GC, please do it correctly.

Regardning Languages.yml folder, please avoid making multiple variations, just regroup it in one languages.yml file or seperate them like you did but also those in languages.yml

example animals.yml can be their own thing. Right now slightly, its a tiny mess.

Also is it possible to to edit MaxItems on characterItemGroup with a trait?

Okay! Now that I'm not distracted, I've gone ahead and made improvements to the organization of the Languages folder.
Also, unfortunately I don't think it's currently possible to let a trait modify the max selections of a characterItemGroup. I will actually have to code this, because I've also thought of doing this by the way!

@FoxxoTrystan FoxxoTrystan requested review from a team, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team September 20, 2024 19:54
@VMSolidus
Copy link
Member Author

Okay, last thing to do. I've gone ahead and setup subcategories for the Speech tab, so that it now includes tabs for Accents and Languages. Which now include more appropriate language related traits. There's also now a characterItemGroup for Accents, so that people can't grief by taking 5+ accents.

image

image

@VMSolidus VMSolidus merged commit def63b6 into Simple-Station:master Sep 20, 2024
11 checks passed
SimpleStation14 added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants