-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enemies and Allies Content Port #956
Enemies and Allies Content Port #956
Conversation
batch of changes I made for Floof station ported over to the upstream branch
RSI Diff Bot; head commit 28d3e2b merging into b53b555 Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi
Resources/Textures/Mobs/Animals/patriarch.rsi
Resources/Textures/Mobs/Animals/subject7355.rsi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nitpicky directory stuff from me :3
folders moved appropriately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire changelog should be just 1-2 entries, and should not include technical details.
better? |
It should also be descriptive for someone who's reading it in the menu. "Added new neutral xeno prototypes for admins to use in events" or something similar would be good. |
I listed a bit better what all was added but I did it in one entry, better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that's fine now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for Rouney Sprite, i dont think those additions are needed.
Those Neutral things were things you done mostly for floof, il let solidus view it.
it was requested. |
Or well, it would be when the Linter fail is fixed. That's legitimate. |
whoops forgot to change the texture paths, my bad |
fix Signed-off-by: fenndragon <[email protected]>
adding proper event messages Signed-off-by: fenndragon <[email protected]>
added 3 more spawn types for vent critters Signed-off-by: fenndragon <[email protected]>
added all event text Signed-off-by: fenndragon <[email protected]>
went ahead and just added 3 more events and fixed the event text in the locale while I was thinking about it |
Signed-off-by: fenndragon <[email protected]>
Signed-off-by: fenndragon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New Events in general just remove all the uniquness of anomalies that can spawn it ect...
And some of them does not fit, i would not approve something like this, review goes to others for it.
that's fine, and I was going to leave it at that but it was then requested as a feature personally by others to port it upstream so that's what I'm doing. |
capitalized the sprite target Signed-off-by: SleepyScarecrow <[email protected]>
Signed-off-by: fenndragon <[email protected]>
Signed-off-by: fenndragon <[email protected]>
Signed-off-by: fenndragon <[email protected]>
Description
This is a batch of changes I made for Floof station being ported over to the upstream branch
Changelog
🆑