Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random Announcer System #21

Closed
wants to merge 51 commits into from
Closed

Random Announcer System #21

wants to merge 51 commits into from

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Nov 4, 2023 •
edited
Loading

Description

Replaces every instance of station announcements with an announcer system meant to handle audio and messages for various announcers defined in prototypes instead of each server replacing the scattered files inconsistently with whatever singular thing they want to hear announce messages.

TODO

  • Systems
  • CVars
  • Sounds
  • Client volume slider
  • Collections
  • Prototypes
  • Events
  • Commands
  • PR media
  • Deglobalize
  • Passthrough localization parameters to overrides
  • Make every announcer follow the template
  • Move sounds into subdirectories
  • Make announcement IDs camelCased
  • Test announcement localizations
  • Weighted announcer lists

Media

2024-01-31_21-15-21.mp4

Changelog

🆑

  • add: Added fun!
  • tweak: Tweaked fun!
  • fix: Fixed fun!
  • remove: Removed fun!

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 4, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Dec 17, 2023
Open
75 tasks
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jan 29, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 2-Large For large issues/PRs Priority: 2-High Needs to be resolved as soon as possible labels Jan 29, 2024
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Jan 29, 2024
@DEATHB4DEFEAT
update template
c00b5dd
@DEATHB4DEFEAT
fix default file paths for announcers
2c8ace2
@DEATHB4DEFEAT
rename SSCVars to PSCVars
9370b46
@DEATHB4DEFEAT
forgot to fix NEIL and Intern paths
b07c245
@DEATHB4DEFEAT
fix empty announcements
1604abe
@DEATHB4DEFEAT
rename complete to Complete
b66de8e
@DEATHB4DEFEAT
update template
371acb0
@DEATHB4DEFEAT
fix announcements playing that shouldn't
d5a47d9
@DEATHB4DEFEAT
reformat and improve announcement IDs
1133abf
@DEATHB4DEFEAT
move Intern sound collections from StatusEffects folder
411f25d 
oops
@DEATHB4DEFEAT
fix announcer announcement formatting and announcement locales
7915294
@DEATHB4DEFEAT
fix SharedAnnouncerSystem not being fully merged with AnnouncerSystem
b035eaf
@DEATHB4DEFEAT
add the Delta-V announcer Michael
4f5652f
@DEATHB4DEFEAT
add localizationTest and improve fallbackTest
f746110
@DEATHB4DEFEAT
fix test failures
f8eb4ec
@DEATHB4DEFEAT
fix spawnAnnounceCaptain announcement
bef13fe
@DEATHB4DEFEAT
fix casing of PowerSinkExplosion announcement
75a8c73
@DEATHB4DEFEAT
add announcerOverride option to everything
e7d6170
@DEATHB4DEFEAT
fix Automated command_report sound file name
8a06392
@DEATHB4DEFEAT
rewrite the announce command
e4e66b0
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review April 13, 2024 20:00
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Apr 13, 2024
@DEATHB4DEFEAT
Copy link
Member Author

I'll try to move this over to Einstein Engines before it's merged here. In the meantime, review please :)

@DEATHB4DEFEAT DEATHB4DEFEAT added Status: Do Not Merge Do not merge Type: Feature Approved additions or changes to a feature to do Type: Codebase Approved issues with the codebase to resolve labels Apr 13, 2024
VMSolidus
VMSolidus approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice. :)

@DEATHB4DEFEAT
Copy link
Member Author

Simple-Station/Einstein-Engines#415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist Pspritechologist is a code owner

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 2-Large For large issues/PRs Status: Do Not Merge Do not merge Status: Needs Review Someone please review this Type: Codebase Approved issues with the codebase to resolve Type: Feature Approved additions or changes to a feature to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DEATHB4DEFEAT @VMSolidus