Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Law Improvements #182

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Law Improvements #182

merged 6 commits into from
Aug 15, 2023

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Jul 15, 2023 •
edited
Loading

Media

image

Changelog

🆑

  • add: Law UIs show a name and description for the current lawset.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Jul 15, 2023
@github-actions github-actions bot added the Changes: UI Changes any XAML files label Jul 15, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 3-Medium Needs to be resolved at some point Size: Small For small issues/PRs labels Jul 15, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review July 15, 2023 01:49
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jul 15, 2023
Pspritechologist
Pspritechologist approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Pspritechologist Pspritechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge with these changes.

Resources/Locale/en-US/SimpleStation14/Prototypes/Laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Prototypes/Laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Prototypes/Laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Prototypes/Laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Prototypes/Laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Prototypes/Laws/laws.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Prototypes/Laws/laws.ftl Outdated Show resolved Hide resolved
@Pspritechologist
Copy link
Member

Meant to request changes :P

@Pspritechologist
Copy link
Member

These changes are mostly aimed with the idea that the multiple lawsets are due to AIs being highly experimental, and the engineers setting them up not knowing what will work best. The descriptions are meant to be user-facing, giving an quick explanation of the lawset.
(I know they're not visible in game yet)

Perhaps there truly is safety in brevity? :P

@DEATHB4DEFEAT @Pspritechologist
Apply suggestions from code review
bec4a34 
Co-authored-by: Pspritechologist <[email protected]>
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 780e781 into master Aug 15, 2023
5 of 13 checks passed
@DEATHB4DEFEAT DEATHB4DEFEAT deleted the law-improvements branch August 15, 2023 22:59
SimpleStation14 added a commit that referenced this pull request Aug 15, 2023
@SimpleStation14
Automatic Changelog Update (#182)
6f13154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pspritechologist Pspritechologist Pspritechologist approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: Small For small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DEATHB4DEFEAT @Pspritechologist