Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin New Player Notification Sound #200

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Admin New Player Notification Sound #200

merged 4 commits into from
Aug 31, 2023

Conversation

DEATHB4DEFEAT
Copy link
Member

Description

Adds a quick ping sound that plays to every active (not de-adminned) admin whenever a new player joins.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Aug 30, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 5-Whenever Doesn't matter when this gets resolved Size: Very Small For especially small issues/PRs labels Aug 31, 2023
Pspritechologist
Pspritechologist requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Pspritechologist Pspritechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the sound is very goofy.

Pspritechologist
Pspritechologist requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Pspritechologist Pspritechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a late review-
This should be a cvar, not every downstream will want it. Especially for a brand new server- that would be annoying.

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 31, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit a0c76bf into master Aug 31, 2023
6 of 14 checks passed
@DEATHB4DEFEAT DEATHB4DEFEAT deleted the newplayerping branch August 31, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pspritechologist Pspritechologist Pspritechologist approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Priority: 5-Whenever Doesn't matter when this gets resolved Size: Very Small For especially small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DEATHB4DEFEAT @Pspritechologist