Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic's Generic planet lobby BG #88

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Generic's Generic planet lobby BG #88

wants to merge 8 commits into from

Conversation

SomewhatSad14
Copy link

@SomewhatSad14 SomewhatSad14 commented Apr 11, 2023 •
edited by DEATHB4DEFEAT
Loading

Description

A new lobby background with planets in the shape of the big/little dipper.

Changelog

🆑 Generic

  • add: Added planets lobby screen was added
  • tweak: Froze earth

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Apr 11, 2023
DEATHB4DEFEAT
DEATHB4DEFEAT approved these changes Apr 11, 2023
View reviewed changes
Resources/Prototypes/lobbyscreens.yml Outdated Show resolved Hide resolved
Resources/Textures/LobbyScreens/attributions.yml Outdated Show resolved Hide resolved
Pspritechologist
Pspritechologist requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Pspritechologist Pspritechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mentioned about the file name. Other than that, looks good to me.

Resources/Prototypes/lobbyscreens.yml Show resolved Hide resolved
@Pspritechologist
Copy link
Member

You should edit the PR name and description to uh
Be something :P

@DEATHB4DEFEAT DEATHB4DEFEAT added the Status: Awaiting Changes Do not merge due to requested changes label Apr 26, 2023
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Apr 30, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@SomewhatSad14 SomewhatSad14 changed the title Planets.LobbyBG Generic's Generic planet lobby BG May 7, 2023
SomewhatSad14 and others added 2 commits May 7, 2023 02:06
@SomewhatSad14
YML Updated
3b5dd4b 
Changed Planets to - Dipper, because the planets make the Ursa major? constellation (might be Ursa minor)
@SomewhatSad14 @DEATHB4DEFEAT
Apply suggestions from code review
2fbda27 
Co-authored-by: DEATHB4DEFEAT <[email protected]>
@github-actions github-actions bot removed the Status: Awaiting Changes Do not merge due to requested changes label May 7, 2023
@Pspritechologist
Copy link
Member

Edit the PR description to be something basic, it gets saved in the commit history.

@Pspritechologist
Copy link
Member

Don't merge this until the pr description is like, anything. A changelog isn't needed, a checklist isn't needed, but just state what it does, please.

@DEATHB4DEFEAT
Copy link
Member

Don't merge this until the pr description is like, anything. A changelog isn't needed, a checklist isn't needed, but just state what it does, please.

you have permission to edit it

@DEATHB4DEFEAT
Copy link
Member

image

@Pspritechologist
Copy link
Member

Don't merge this until the pr description is like, anything. A changelog isn't needed, a checklist isn't needed, but just state what it does, please.

you have permission to edit it

I am well aware.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label May 21, 2023
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 23, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEATHB4DEFEAT DEATHB4DEFEAT DEATHB4DEFEAT requested changes

@Pspritechologist Pspritechologist Pspritechologist approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes: YML Changes any yml files Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SomewhatSad14 @Pspritechologist @DEATHB4DEFEAT