Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character Information UI #99

Merged
merged 22 commits into from
Aug 29, 2023
Merged

Character Information UI #99

merged 22 commits into from
Aug 29, 2023

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Apr 20, 2023 •
edited
Loading

TODO

  • Placeholder flavor text locale
  • Rename the system
  • Remove other examine verbs this system covers
  • Display the job icon with the job title
  • Colored job title
  • Settle on how the departments should be ordered
  • Check ic.flavor_text cvar
  • Freeze the SpriteViews
  • Make IPCs examinable

Media

Character creation

image

No flavor text or flavor texts are disabled

image

There is a flavor text and flavor texts are enabled

image

Examine verb

image

Changelog

🆑

  • add: Added an examine UI for viewing information about crewmembers
  • remove: Removed SpriteView ("View Closely") UI in favor of the new character information UI
  • add: Added support for very large, multi line flavor texts
  • remove: Removed examine verbs with contents covered by new examine UI

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: UI Changes any XAML files labels Apr 20, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title multiline flavortext Character Information UI May 16, 2023
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 16, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 2-High Needs to be resolved as soon as possible Size: Small For small issues/PRs Status: Needs Discussion Must be discussed and removed Status: Needs Review Someone please review this labels May 16, 2023
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label May 17, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review May 17, 2023 04:30
@DEATHB4DEFEAT DEATHB4DEFEAT added Status: Do Not Merge Do not merge Status: Needs Cleanup Someone has to clean this before merging labels May 17, 2023
@DEATHB4DEFEAT
Copy link
Member Author

Temporary DNM, needs discussion and a bit of cleanup

@github-actions github-actions bot added the Changes: YML Changes any yml files label May 18, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT removed Status: Do Not Merge Do not merge Status: Needs Cleanup Someone has to clean this before merging Status: Needs Discussion Must be discussed labels May 18, 2023
Pspritechologist
Pspritechologist requested changes May 20, 2023
View reviewed changes
...nt.Client/SimpleStation14/Examine/CharacterInformation/Systems/CharacterInformationSystem.cs Outdated Show resolved Hide resolved
...nt.Client/SimpleStation14/Examine/CharacterInformation/Systems/CharacterInformationSystem.cs Outdated Show resolved Hide resolved
...nt.Client/SimpleStation14/Examine/CharacterInformation/Systems/CharacterInformationSystem.cs Outdated Show resolved Hide resolved
...nt.Client/SimpleStation14/Examine/CharacterInformation/Systems/CharacterInformationSystem.cs Outdated Show resolved Hide resolved
...nt.Client/SimpleStation14/Examine/CharacterInformation/Systems/CharacterInformationSystem.cs Outdated Show resolved Hide resolved
...nt.Client/SimpleStation14/Examine/CharacterInformation/Systems/CharacterInformationSystem.cs Outdated Show resolved Hide resolved
...nt.Client/SimpleStation14/Examine/CharacterInformation/Systems/CharacterInformationSystem.cs Outdated Show resolved Hide resolved
Content.Client/SimpleStation14/Examine/CharacterInformation/UI/CharacterInformationWindow.xaml Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Content/CharacterInformation/characterInformationUi.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/SimpleStation14/Content/CharacterInformation/characterInformationUi.ftl Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 7, 2023
@github-actions github-actions bot added Status: Merge Conflict FIX YOUR PR AAAGH and removed Status: Merge Conflict FIX YOUR PR AAAGH labels Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Aug 25, 2023
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 25, 2023
Pspritechologist
Pspritechologist requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@Pspritechologist Pspritechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI needs to close when you walk away from people, so you can't just take their image with you on a walk.

Content.Server/Station/Systems/StationSpawningSystem.cs Outdated Show resolved Hide resolved
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit c2f737b into master Aug 29, 2023
5 of 13 checks passed
@DEATHB4DEFEAT DEATHB4DEFEAT deleted the multiline-flavortext branch August 29, 2023 04:06
SimpleStation14 added a commit that referenced this pull request Aug 29, 2023
@SimpleStation14
Automatic Changelog Update (#99)
0a93bb0
@DEATHB4DEFEAT DEATHB4DEFEAT added this to the Cool Roleplay Things milestone Sep 12, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pspritechologist Pspritechologist Pspritechologist approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: Small For small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
Cool Roleplay Things
Development

Successfully merging this pull request may close these issues.
2 participants
@DEATHB4DEFEAT @Pspritechologist