Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Raise dependency versions and switch to java 8 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baunz
Copy link

@baunz baunz commented Aug 31, 2022

The method used to retrieve the metric value has been deprecated in Kafka 3 (https://issues.apache.org/jira/browse/KAFKA-12573). This raises the kafka and metrics libraries version and uses the current API. This makes Kafka version 1.0.0 mandatory.

Note: I don't know if this project is still maintained but it is worth a try :)

The method used to retrieve the metric value has been deprecated in Kafka 3 (https://issues.apache.org/jira/browse/KAFKA-12573). This raises the kafka and metrics libraries version and uses the current API. This makes Kafka version 1.0.0 mandatory.
@jklukas
Copy link
Contributor

jklukas commented Aug 31, 2022

Note: I don't know if this project is still maintained but it is worth a try :)

You're the first to ask for a change in quite a few years. This change looks reasonable, so it's possible to merge it, but I'm fairly certain I no longer have the credentials to be able to upload to the sonatype repository. I also have not used Kafka actively in years.

If you're interested in forking this and maintaining it, I'd be happy to pass off to that as the canonical version and document it as such here.

@baunz
Copy link
Author

baunz commented Aug 31, 2022

Hey Jeff,

thanks for the quick response and the offer, it sounds like a good solution! What is your idea of forking and maintaining it? It would probably be a good idea to rename the packages, wouldn't it?

Have a nice day

@jklukas
Copy link
Contributor

jklukas commented Sep 1, 2022

Hey Jeff,

thanks for the quick response and the offer, it sounds like a good solution! What is your idea of forking and maintaining it? It would probably be a good idea to rename the packages, wouldn't it?

Have a nice day

I'd be happy to have a successor project keep the name kafka-dropwizard-reporter, but yes the java package name I think would have to change as we likely can no longer access the com.simple namespace and the company no longer exists.

I haven't interacted with sonatype in years. Do you have any experience with releasing public java packages?

@baunz
Copy link
Author

baunz commented Sep 1, 2022

Not yet. I thought it maybe would be enough to use github to host the jars, but that was mainly driven by the fact that I use the raw jar to include in docker build files, where it makes no big difference if the absolute url to retrieve it points to a github relase or some on maven.org.
But I have to admit that it is much easier to use maven central for projects that include the artifact as a dependency via package managers like maven. So I will try to get that done on my fork after renaming the packages

BR Johannes

@baunz
Copy link
Author

baunz commented Oct 27, 2022

That took a while but now it's done.

<dependency>
  <groupId>io.github.baunz</groupId>
  <artifactId>kafka-dropwizard-reporter</artifactId>
  <version>1.2.0</version>
</dependency>

So this request can be closed and you can maybe include a link :)

jklukas added a commit to jklukas/kafka-dropwizard-reporter that referenced this pull request Oct 28, 2022
@jklukas
Copy link
Contributor

jklukas commented Oct 28, 2022

Looks like I no longer have write access here, so cannot merge changes to update the README, which is unfortunate. I'll see if I can find someone who still can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants