ENH: Added downoading a dictionary from a URL. #65
Conversation
| @@ -490,6 +490,7 @@ def comment_spell_check(args): | |||
|
|
|||
|
|
|||
| def main(): | |||
| """Main function to run the spell checker.""" | |||
There was a problem hiding this comment.
Please provide some additional information in the comment, otherwise it can be removed. The comment is just underneath the function name "main" and only says "Main function..." which is pretty obvious.
| @@ -22,13 +24,44 @@ def create_checker(dict_list: list[str] = None) -> spellchecker.SpellChecker: | |||
| english_dict = str(lib_path) + "/resources/en.json.gz" | |||
| logger.info("Loading English dictionary from: %s", english_dict) | |||
| checker.word_frequency.load_dictionary(english_dict) | |||
| logger.info("# of words: %d", checker.word_frequency.unique_words) | |||
|
|
|||
| # load the additional dictionaries | |||
| if not isinstance(dict_list, list): | |||
| return checker | |||
There was a problem hiding this comment.
I would do:
if dict_list is None:
return checker
I don't think the if Len below is needed.
| except IsADirectoryError: | ||
| # if a directory is provided, load all text files in it | ||
| for file in d.glob("*.txt"): | ||
| try: |
There was a problem hiding this comment.
Maybe just append the globe files to the end of the dict_list
There was a problem hiding this comment.
Yeah, that code was suggested by Copilot.
There was a problem hiding this comment.
Is there any need to support this directory stuff?
There was a problem hiding this comment.
Not really, but, hey, if our Copilot AI overlords say it should be there, who are we to disagree?
There was a problem hiding this comment.
Please be responsible for the code you commit, and don't create redundant, convoluted overly nested code.
No description provided.