feat(BambooLLM): adding implementation for bamboollm updated version #1462
Conversation
dosubot
bot
added
the
size:S
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ffae0d6 in 47 seconds
More details
- Looked at
87lines of code in4files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. pandasai/dataframe/base.py:264
- Draft comment:
The error message should be updated to match the corrected environment variable names:PANDASAI_API_URLandPANDASAI_API_KEY. - Reason this comment was not posted:
Marked as duplicate.
2. pandasai/helpers/request.py:106
- Draft comment:
The error message should be updated to match the corrected environment variable names:PANDASAI_API_URLandPANDASAI_API_KEY. - Reason this comment was not posted:
Marked as duplicate.
3. pandasai/helpers/request.py:67
- Draft comment:
Ensure that the header keyx-authorizationis used consistently across the codebase for authorization. - Reason this comment was not posted:
Comment did not seem useful.
4. pandasai/__init__.py:90
- Draft comment:
"Set PANDASAI_API_URL and PANDASAI_API_KEY in the environment to pull the dataset from the remote server"
- Reason this comment was not posted:
Marked as duplicate.
5. pandasai/dataframe/base.py:264
- Draft comment:
"Set PANDASAI_API_URL and PANDASAI_API_KEY in the environment to pull the dataset from the remote server"
- Reason this comment was not posted:
Marked as duplicate.
6. pandasai/helpers/request.py:106
- Draft comment:
"Set PANDASAI_API_URL and PANDASAI_API_KEY in the environment to push/pull the dataset to/from the remote server"
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_i3E9TQ4kVMSrR8d3
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
pandasai/llm/bamboo_llm.py
Outdated
| response = self._session.post( | ||
| "/query", json={"prompt": instruction.to_string()} | ||
| ) | ||
| print(response) |
There was a problem hiding this comment.
Remove the print(response) statement. Debugging statements should not be present in production code.
pandasai/__init__.py
Outdated
| if not api_url or not api_key: | ||
| raise PandasAIApiKeyError( | ||
| "Set PANDAAI_API_URL and PANDAAI_API_KEY in environment to pull dataset from the remote server" | ||
| "Set PANDASAI_API_URL and PANDAAI_API_KEY in environment to pull dataset from the remote server" |
There was a problem hiding this comment.
The error message should be updated to match the corrected environment variable names: PANDASAI_API_URL and PANDASAI_API_KEY.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1c7acb1 in 27 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pandasai/llm/bamboo_llm.py:21
- Draft comment:
Consider adding error handling for the_session.postcall to manage potential exceptions and ensure the method returns a valid response or error message. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_aQ4W9zxkSTZzonrE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on c07310e in 33 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pandasai/__init__.py:90
- Draft comment:
The environment variable names have been correctly updated toPANDASAI_API_URLandPANDASAI_API_KEYas per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions changing the environment variable names, and this change is correctly reflected in the code.
Workflow ID: wflow_JJFY58kIKAYvxUyq
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
pandasai/__init__.py
Outdated
| if not api_url or not api_key: | ||
| raise PandasAIApiKeyError( | ||
| "Set PANDAAI_API_URL and PANDAAI_API_KEY in environment to pull dataset from the remote server" | ||
| "Set PANDASAI_API_URL and PANDASAI_API_KEY in environment to pull dataset from the remote server" |
There was a problem hiding this comment.
The error message can be improved for clarity and conciseness:
| "Set PANDASAI_API_URL and PANDASAI_API_KEY in environment to pull dataset from the remote server" | |
| "Please set the PANDASAI_API_URL and PANDASAI_API_KEY environment variables to pull the dataset from the remote server." |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Important
Corrects environment variable names, updates request headers, and modifies BambooLLM implementation for improved functionality.
PANDAAI_API_KEYtoPANDASAI_API_KEYandPANDAAI_API_URLtoPANDASAI_API_URLin__init__.py,base.py, andrequest.py.Authorizationheader tox-authorizationinmake_request()inrequest.py.call()method inbamboo_llm.pyto use/queryendpoint and returnresponse["answer"].This description was created by
for c07310e. It will automatically update as commits are pushed.