Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in smart_dataframe breaking import #1468

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

gdcsinaptik
Copy link
Collaborator

@gdcsinaptik gdcsinaptik commented Dec 10, 2024

Description

This PR fixes an issue in the smart_dataframe/init.py file that was causing import errors.

Changes Made

  • Fixed import path in pandasai/smart_dataframe/init.py

Testing

  • Verified that imports work correctly after the fix

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Important

Fixes string concatenation in deprecation warning message in smart_dataframe/__init__.py.

  • Bug Fix:
    • Corrected string concatenation in deprecation warning message in __init__.py of smart_dataframe.
    • Ensures proper display of the message: "SmartDataframe will soon be deprecated. Please use df.chat() instead."

This description was created by Ellipsis for b6a56f2. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 10, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b6a56f2 in 11 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pandasai/smart_dataframe/__init__.py:32
  • Draft comment:
    The string concatenation fix is correct and ensures the deprecation warning message is properly formatted.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly fixes the string concatenation issue in the deprecation warning message. This change ensures that the warning message is properly formatted and displayed.

Workflow ID: wflow_egzOuj2z3ReuyGR5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@ArslanSaleem ArslanSaleem merged commit 496e307 into release/v3 Dec 10, 2024
0 of 6 checks passed
@ArslanSaleem ArslanSaleem deleted the testing/fix-import branch December 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants