Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes for type hints:
List[CustomType]
type doesn't seem to be an appropriate type when passing multiple arguments to a function.See the screenshot below:
Instead, when covering asterisk arguments with type hints, i suggest to use
Optional[CustomType]
(Optional
means that the function de-facto can accept 0 arguments).Further notation: the
Unpack
type can appear in 3.12 according to PEP-0692, exactly for such cases.Summary by CodeRabbit
add_middlewares
method in thePandasAI
class across multiple modules (code_manager.py
,smart_dataframe/__init__.py
, andsmart_datalake/__init__.py
). The method now accepts an optionalMiddleware
type instead of a list ofMiddleware
. This change enhances flexibility when adding middlewares to thePandasAI
instance, allowing users to add multiple middlewares as separate arguments rather than passing them as a list.