Remove outdated variable #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiemckeon
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
LGTM.
I read through the full sindri.py code to ensure there were no subtle dependencies on this variable. I can see that there must have been a refactor to move away from so many settings being intrinsically linked to the sindri client.
On that same note, you set the client __version__ as 0.0.0 which is not at all current with the package release tag.
0.0.0 is the default in the code. Our github action that publishes the sdk to PyPI replaces the 0.0.0 default version with the release tag that triggered the action workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a one-liner that removes an outdated variable that was left in by mistake.