Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new status endpoints for circuit/proof polling #52

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Use new status endpoints for circuit/proof polling #52

merged 3 commits into from
Aug 21, 2024

Conversation

KPreisner
Copy link
Member

@KPreisner KPreisner commented Aug 15, 2024 •
edited
Loading

This PR incorporates new internal sindri api status endpoints for circuits and proofs that are more efficient. They are using when wait=True is supplied to the create_circuit and prove_circuit methods.

Additional tweaks

  • the sindri ascii art logo is smaller
  • the verbose level 1 printout is slightly adjusted

@KPreisner KPreisner self-assigned this Aug 19, 2024
@KPreisner KPreisner marked this pull request as ready for review August 21, 2024 18:18
@KPreisner KPreisner requested a review from sangaline August 21, 2024 18:18
@KPreisner KPreisner assigned sangaline and unassigned KPreisner Aug 21, 2024
sangaline
sangaline approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@sangaline sangaline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KPreisner KPreisner merged commit c6b564d into main Aug 21, 2024
2 checks passed
@KPreisner KPreisner deleted the kp-slim-status-endpoint branch August 21, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangaline sangaline sangaline approved these changes

Assignees

@sangaline sangaline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KPreisner @sangaline