Skip to content

Commit

Permalink
Add noirVersion to Noir circuits (#71)
Browse files Browse the repository at this point in the history
This PR updates all of our current Noir circuits (both in
`circuit_database/` and in `circuit_tutorials/`) to include the new
field from the Sindri manifest: `noirVersion`. This field allows users
to specify whether we should apply the Noir prover version [0.17.0,
0.18.0, 0.19.4, 0.22.0, 0.23.0]. This is the first of two PR's that
patches our existing circuits, which have been assuming the 0.17.0
prover version. The next PR introduces more circuits of other versions -
see #70

## Reviewer Testing:
- [x] For each compressed circuit in `circuit_database/noir`, submit to
the frontend (stage server) and ensure compilation is successful:
  - [ ] not_equal.tar.gz
  - [ ] not_equal.zip
  - [x] decision_tree.tar.gz
  - [x] decision_tree.zip
  - [x] billion_zk_vote.tar.gz
  - [x] billion_zk_vote.zip
- [x] Ensure the `sindri.json` file at
`circuit_tutorials/noir/pagerank/circuits` has a field for the
`noirVersion` and that it is set to `0.17.0`
  • Loading branch information
katiemckeon authored Feb 12, 2024
1 parent 0182c69 commit 6aee1c0
Show file tree
Hide file tree
Showing 10 changed files with 8 additions and 4 deletions.
Binary file modified circuit_database/noir/billion_zk_vote.tar.gz
Binary file not shown.
Binary file modified circuit_database/noir/billion_zk_vote.zip
Binary file not shown.
3 changes: 2 additions & 1 deletion circuit_database/noir/billion_zk_vote/sindri.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"$schema": "https://sindri.app/api/v1/sindri-manifest-schema.json",
"circuitType": "noir",
"name": "billion-zk-vote",
"provingScheme": "barretenberg"
"provingScheme": "barretenberg",
"noirVersion": "0.17.0"
}
Binary file modified circuit_database/noir/decision_tree.tar.gz
Binary file not shown.
Binary file modified circuit_database/noir/decision_tree.zip
Binary file not shown.
3 changes: 2 additions & 1 deletion circuit_database/noir/decision_tree/sindri.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"$schema": "https://sindri.app/api/v1/sindri-manifest-schema.json",
"circuitType": "noir",
"name": "decision-tree",
"provingScheme": "barretenberg"
"provingScheme": "barretenberg",
"noirVersion": "0.17.0"
}
Binary file modified circuit_database/noir/not_equal.tar.gz
Binary file not shown.
Binary file modified circuit_database/noir/not_equal.zip
Binary file not shown.
3 changes: 2 additions & 1 deletion circuit_database/noir/not_equal/sindri.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"$schema": "https://sindri.app/api/v1/sindri-manifest-schema.json",
"circuitType": "noir",
"name": "neq",
"provingScheme": "barretenberg"
"provingScheme": "barretenberg",
"noirVersion": "0.17.0"
}
3 changes: 2 additions & 1 deletion circuit_tutorials/noir/pagerank/circuits/sindri.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"$schema": "https://sindri.app/api/v1/sindri-manifest-schema.json",
"name": "pagerank",
"circuitType": "noir",
"provingScheme": "barretenberg"
"provingScheme": "barretenberg",
"noirVersion": "0.17.0"
}

0 comments on commit 6aee1c0

Please sign in to comment.